Skip to content

fix: ensure mime box is large enough to read #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobbee merged 1 commit into from
Jan 20, 2025
Merged

fix: ensure mime box is large enough to read #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mp4/mime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package mp4

import (
"fmt"
"io"

"github.com/Eyevinn/mp4ff/bits"
Expand Down Expand Up @@ -31,6 +32,9 @@ func DecodeMimeSR(hdr BoxHeader, startPos uint64, sr bits.SliceReader) (Box, err
Version: byte(versionAndFlags >> 24),
Flags: versionAndFlags & flagsMask,
}
if hdr.payloadLen() < 5 {
return nil, fmt.Errorf("mime: box payload size %d less than 5", hdr.payloadLen())
}
rest := sr.ReadBytes(hdr.payloadLen() - 4)
if rest[len(rest)-1] == 0 { // zero-termination
b.ContentType = string(rest[:len(rest)-1])
Expand Down
2 changes: 2 additions & 0 deletions mp4/testdata/fuzz/FuzzDecodeBox/77cf6e30648805ea
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
go test fuzz v1
[]byte("\x00\x00\x00\fmime0000")