Update effects every tick

[Hdt80bro]

Changes all effects to update their position and visibility every tick, instead of just beam effects.

Summary by CodeRabbit

• Bug Fixes
  • Increased update frequency for non-trail visual effects and emitter positions (now updated every frame), improving responsiveness and producing smoother, more accurate effect animations.

[coderabbitai]

Warning

Rate limit exceeded

@Hdt80bro has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 30 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

The hooks/EffectUpdates.hook file modifies update frequencies for visual effects. Non-trail effects' visibility checks now occur every tick instead of every 5 ticks, and emitter position updates now occur every tick instead of every 3 ticks.

Changes

Cohort / File(s)	Summary
Effect Update Frequency Adjustments hooks/EffectUpdates.hook	Modified visibility checks for non-trail effects (Moho::CEfxEmitter::CanSeeCam, Moho::CEfxBeam::CanSeeCam, Moho::CEfxTrail::CanSeeCam) to run every tick (was every 5 ticks). Changed Moho::CEfxEmitter::OnTick to update emitter position every tick (was every 3 ticks).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hop through ticks both near and far,
Checking sights each tiny spar.
Emitters bound with nimble cheer,
Beams and trails draw closer, clear.
A joyful twitch — the pixels hear! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is vague and incomplete; it lacks the structured sections required by the template (memo, checklist items), missing details about changes, testing, and README updates.	Expand the description to include the structured memo section with clear details about what changed and why, and add a checklist showing completion of required items like documentation and testing.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: updating effects to occur every tick instead of at longer intervals.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into master

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}