More clear UI and text for mathcmaker vetoes

[K-ETFreeman]

Closes #3488

20260309-2054-42.0670903.mp4

Summary by CodeRabbit

• New Features

  • Enhanced map banning interface with visual indicators for fully and partially banned maps, including grayscale effects and status stripes on map tiles.

• Documentation & Localization

  • Updated terminology from "veto" to "map ban" throughout the UI for clarity.
  • Added Russian language translations for map banning features.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fa0b9177-337c-4cd9-ad0e-8c4560e2b90d

📥 Commits

Reviewing files that changed from the base of the PR and between a402032 and d539921.

📒 Files selected for processing (5)

• src/main/java/com/faforever/client/teammatchmaking/TeamMatchmakingMapTileController.java
• src/main/resources/i18n/messages.properties
• src/main/resources/i18n/messages_ru.properties
• src/main/resources/theme/play/teammatchmaking/matchmaking_map_tile.fxml
• src/main/resources/theme/style.css

---

📝 Walkthrough

Walkthrough

This PR enhances the team matchmaker UI to make map bans more visually obvious by adding a "banned" stripe label to map tiles, applying grayscale effects to banned map thumbnails, updating terminology from "veto" to "map bans," and adding corresponding styling and translations in English and Russian.

Changes

Cohort / File(s)	Summary
Map Tile Visual Enhancement src/main/java/com/faforever/client/teammatchmaking/TeamMatchmakingMapTileController.java, src/main/resources/theme/play/teammatchmaking/matchmaking_map_tile.fxml, src/main/resources/theme/style.css	Adds bannedStripe label UI element, implements ban state detection logic (isFullBan and hasTokens computation), applies banned CSS class and grayscale effect to thumbnails, controls label visibility and text based on partial vs. full ban status, and adds corresponding CSS styling for the stripe element and text colors.
Localization Updates src/main/resources/i18n/messages.properties, src/main/resources/i18n/messages_ru.properties	Adds new translation keys for map ban UI text (map.banned_thinSpaced, map.partiallyBanned) and updates terminology from "veto" to "map bans" in notification/settings titles and button labels; provides English and Russian translations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• FAForever/downlords-faf-client#3428: Directly modifies the same TeamMatchmakingMapTileController and map tile UI components to handle map bans/veto state and styling.

Suggested reviewers

• Sheikah45

Poem

🐰 A stripe of truth now gleams so bright,
Where banned maps dim in grayscale sight,
No more confusion, vetos clear—
Now "bans" are obvious, loud and dear! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title mentions 'mathcmaker vetoes' but should reference 'map bans' terminology; however, it partially aligns with the changeset's focus on improving UI clarity for map banning.
Linked Issues check	✅ Passed	All changes directly address issue #3488: terminology updated from 'veto' to 'map ban', UI enhanced with visible 'BANNED' stripe on banned maps, and all localization strings support the improved clarity.
Out of Scope Changes check	✅ Passed	All changes are scoped to making map bans more obvious; no unrelated modifications detected in files changed.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/veto-system-ui-improvements

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}