Campaign code improvements and fixes #6984
Draft
+1,666
−1,625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speed2CZ
added
area: sim
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AttackFormation - the wide one is desirable in most of the cases
Long time ago AttackManager got split from the AiBrain, some fields go renamed, but this one was forgotten.
speed2CZ
force-pushed
the
campaignImprovements
branch
2 times, most recently
from
3b399f0 to
5d35e4e
Compare
Fixes FAForever#6983 Seems like the `[2]` value of the vector is used to read the position and `.y` just points to it. So changing `.y` has no effect on the vector
`default_brain` param isnt used anywhere, thats why its being removed. I dont think there's a need to check for it each time when we check the build condition, but only when we're adding the platoon. The build conditions of the campaign platoons rarely change and if they do, they don't contain the param. And if that case happens, its better if the author doesn't include it anymore as it has no effect!
This has no functional change. The name of the platoon is not used in anyway here and empty string is a valid value.
Instead of building just single scout, build as many as there are factories.
When the platoon template is process, some squad units can end up with quantity 0 and those should be removed. table.remove shift all remaining values down, which the old code didnt consider and it was skipping the more squads the more got removed. The fix iterates the table from the back which makes table.remove safe to use
When the platoon builder is loaded `default_brain` is always just deleted from the build conditions. since the army's brain is automatically added to call the build condition as a first param.
- Added missing UEF tag - Increased turn rate
UI doesn't have .Dead There's an error spam when selected ACU or Nuke is killed / deleted, which triggers cinematics
speed2CZ
force-pushed
the
campaignImprovements
branch
from
5d35e4e to
2d6cc8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP, I'll include full description later.
Description of the proposed changes
Testing done on the proposed changes
Additional context
Checklist