adding 'Factories share "Assist" to units' option

[Strogoo]

Options - Gameplay - Commands (ON by default)

Since it's a simple console command, it's possible to make a hotkey instead of toggle to use both "Assist"s. But then we need a different icon for the cursor. Also default one that copies factory queue is pretty useless, so I don't want to spend any time making them both available at the same time. I'll leave it for UI mods

Additional context

requires: FAForever/FA-Binary-Patches#131

1.mp4

Exe for testing in Zulip->engine-development

Summary by CodeRabbit

• New Features
  • Added a new gameplay option: "Factories share 'Assist' to units." This toggle allows players to configure whether factory units automatically share the Assist command with their allied units. When enabled, factories will share assist commands to other units. The option is enabled by default and can be adjusted in the gameplay options menu.

[coderabbitai]

📝 Walkthrough

Walkthrough

A new gameplay option toggle is added to lua/options/options.lua that enables factories to share "Assist" commands to units. When toggled, it executes a console command to propagate the setting.

Changes

Cohort / File(s)	Summary
Gameplay Options Configuration lua/options/options.lua	Added new toggle option factoryShareAssist under gameplay options to control whether factories share "Assist" commands to units; defaults to true and executes ui_ShareFactoryAssistCommandToUnits console command when changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Factories now assist with glee,
Share their commands wild and free,
A toggle flips, the units dance,
A warcraft strategy enhanced! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description provides context and rationale but lacks testing details and changelog documentation as required by the template.	Add section documenting testing performed, and confirm changelog snippet was created per guidelines at https://faforever.github.io/fa/development/changelog#format-of-a-snippet.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely describes the main change: adding a new gameplay option toggle for factory assist sharing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Garanas]

This should be 'off' by default in my opinion, as it changes the behavior of assist commands for factories that people have been used to for the past 15 or so years.