Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/snippets/feature.7054.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- (#7054) Add ability to show allied intel in strategic overlay

By default the intel of allied structures is shared. This default is chosen to make players aware of the new features without cluttering the screen. The game option can be found under Interface -> HUD.
Comment on lines +1 to +3
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Fix changelog snippet format to unblock CI.

The docs pipeline already fails on this file with “Invalid format for changelog file”. Please rewrite this snippet to the repository’s expected changelog snippet template (same format as other files in changelog/snippets).

🧰 Tools
🪛 GitHub Actions: Documentation - Generate changelog

[error] 1-1: Changelog verification failed: Invalid format for changelog file.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@changelog/snippets/feature.7054.md` around lines 1 - 3, Replace the freeform
text in changelog/snippets/feature.7054.md with the repository's changelog
snippet template used by other files in changelog/snippets: add the required
front-matter fields (e.g., pull_request: 7054, type: feature, and relevant
category/area keys) then a short description body summarizing the change ("Add
ability to show allied intel in strategic overlay" and the default behavior and
UI location). Use the same YAML/front-matter keys and format as the other
snippets in changelog/snippets so the docs pipeline accepts it.

20 changes: 20 additions & 0 deletions lua/options/options.lua
Original file line number Diff line number Diff line change
Expand Up @@ -947,6 +947,26 @@ options = {
key = '',
},

{
title = "<LOC Show_Allied_Intel>Show intel of allies in strategic overlay",
key = 'intel_overlay_allies',
type = 'toggle',
default = 1,
set = function(key, value, startup)
ConExecute("ren_IntelRangeBehavior " .. tostring(value))
end,
update = function(control, value)
ConExecute("ren_IntelRangeBehavior " .. tostring(value))
end,
custom = {
states = {
{ text = "<LOC _Off>", key = 0, },
{ text = "<LOC _JustStructures>Only allied structures", key = 1, },
{ text = "<LOC _On>", key = 2, },
},
},
},

{
title = "<LOC OPTIONS_0215>Show Waypoint ETAs",
key = 'display_eta',
Expand Down
4 changes: 4 additions & 0 deletions lua/ui/help/tooltips.lua
Original file line number Diff line number Diff line change
Expand Up @@ -851,6 +851,10 @@ Tooltips = {
title = "<LOC OPTIONS_0283>UI Scale",
description = "<LOC OPTIONS_0284>Changes the size of all UI elements. (requires game restart)",
},
options_show_allied_intel_in_strategic_overlay = {
title = "<LOC Show_Allied_Intel_Title>Show Allied Intel in Strategic Overlay",
description = "<LOC Show_Allied_Intel_Description>Toggles the display of allied intel in the strategic overlay.",
},
Comment on lines +854 to +857
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Tooltip key name does not match the option key mapping.

Line 854 uses options_show_allied_intel_in_strategic_overlay, but the option key is intel_overlay_allies. With the current naming pattern, this prevents automatic tooltip lookup for the new option.

[suggested fix]

Rename tooltip key to match the option key
-options_show_allied_intel_in_strategic_overlay = {
+options_intel_overlay_allies = {
     title = "<LOC Show_Allied_Intel_Title>Show Allied Intel in Strategic Overlay",
     description = "<LOC Show_Allied_Intel_Description>Toggles the display of allied intel in the strategic overlay.",
 },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
options_show_allied_intel_in_strategic_overlay = {
title = "<LOC Show_Allied_Intel_Title>Show Allied Intel in Strategic Overlay",
description = "<LOC Show_Allied_Intel_Description>Toggles the display of allied intel in the strategic overlay.",
},
options_intel_overlay_allies = {
title = "<LOC Show_Allied_Intel_Title>Show Allied Intel in Strategic Overlay",
description = "<LOC Show_Allied_Intel_Description>Toggles the display of allied intel in the strategic overlay.",
},
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@lua/ui/help/tooltips.lua` around lines 854 - 857, Rename the tooltip entry
key to match the option key so automatic lookup works: change
options_show_allied_intel_in_strategic_overlay to intel_overlay_allies while
keeping the title and description values unchanged; update the tooltip table
entry (the object containing title and description) to use intel_overlay_allies
so it matches the option mapping used elsewhere.

options_subtitles = {
title = "<LOC OPTIONS_0151>Display Subtitles",
description = "<LOC OPTIONS_0152>Toggles the display of subtitles during movies",
Expand Down
Loading