Skip to content

Fix torpedoes having difficulties hitting the Cybran Frigate when it is turning#7087

Open
Basilisk3 wants to merge 2 commits intoFAForever:developfrom
Basilisk3:trident_targetbones
Open

Fix torpedoes having difficulties hitting the Cybran Frigate when it is turning#7087
Basilisk3 wants to merge 2 commits intoFAForever:developfrom
Basilisk3:trident_targetbones

Conversation

@Basilisk3
Copy link
Copy Markdown
Collaborator

@Basilisk3 Basilisk3 commented Apr 11, 2026

Description of the proposed changes

As per the title. Closes #6876.

Checklist

Summary by CodeRabbit

  • Bug Fixes
    • Updated a unit's targeting configuration to remove two targeting elements from its active list.
    • Fixed an issue where torpedoes sometimes failed to hit the Cybran Frigate while it was turning.

@Basilisk3 Basilisk3 requested review from BlackYps and lL1l1 April 11, 2026 11:57
@Basilisk3 Basilisk3 added the area: unit-blueprint related to issues in unit blueprints (*_unit.bp) label Apr 11, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: eea25400-d298-4712-b468-71f1bf4a39d4

📥 Commits

Reviewing files that changed from the base of the PR and between 88b40b9 and aa506f2.

📒 Files selected for processing (1)
  • changelog/snippets/fix.7087.md
✅ Files skipped from review due to trivial changes (1)
  • changelog/snippets/fix.7087.md

📝 Walkthrough

Walkthrough

Removed two wake target bones ("Front_Left_Wake", "Front_Right_Wake") from the URS0103 Cybran Frigate unit blueprint's AI.TargetBones list; no other blueprint fields were changed.

Changes

Cohort / File(s) Summary
Unit Configuration
units/URS0103/URS0103_unit.bp
Removed "Front_Left_Wake" and "Front_Right_Wake" from AI.TargetBones.
Changelog
changelog/snippets/fix.7087.md
Added changelog snippet noting PR #7087 fix for torpedoes struggling to hit the Cybran Frigate while turning.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

  • #6876: Torpedoes sometimes have difficulties hitting the Cybran Frigate reliably — this change directly targets the reported target-bone list suspected in that issue.
  • List of naval units without defined target bones #7058: Also involves modifications to AI.TargetBones in naval unit blueprints; aligns with the same class of fixes.

Possibly related PRs

Suggested labels

type: bug

Suggested reviewers

  • lL1l1
  • BlackYps
  • Rhaelya

Poem

🐰 I hopped by the ship on a moonlit tide,
Two wakes I plucked where secrets hide.
Torpedoes find a clearer line,
As Trident turns with sleeker spine.
Hooray for fixes—sea-salt pride!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: fixing torpedo hit reliability on the Cybran Frigate during turning maneuvers.
Description check ✅ Passed The description includes the issue reference and documents completion of required checklist items (changelog snippet and reviewer requests).
Linked Issues check ✅ Passed The code changes directly address issue #6876 by removing problematic target bones (Front_Left_Wake and Front_Right_Wake) from the Trident frigate's TargetBones list.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the torpedo targeting issue: the unit blueprint modification targets the identified problem, and the changelog entry documents the fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: unit-blueprint related to issues in unit blueprints (*_unit.bp)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Torpedoes sometimes have difficulties hitting the Cybran Frigate reliably

1 participant