Skip to content

Only build website when game files have changed#7089

Open
BlackYps wants to merge 1 commit intodevelopfrom
website-deployment
Open

Only build website when game files have changed#7089
BlackYps wants to merge 1 commit intodevelopfrom
website-deployment

Conversation

@BlackYps
Copy link
Copy Markdown
Contributor

@BlackYps BlackYps commented Apr 11, 2026

The website build workflow fails when there are no balance snippets yet on deploy/fafdevelop or deploy/fafbeta. This is normal shortly after a release, but it looks concerning in the github UI.
It makes sense to only run this workflow when an actual deployment of game files has happened.
Or was there a specific reasoning to run on each develop update? @Garanas

Summary by CodeRabbit

  • Chores
    • Updated documentation deployment workflow configuration to trigger from different source branches.

@BlackYps BlackYps requested a review from Garanas April 11, 2026 14:01
@github-actions github-actions bot marked this pull request as draft April 11, 2026 14:01
@BlackYps BlackYps marked this pull request as ready for review April 11, 2026 14:02
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b099b854-31af-4255-8f4e-eb661f58d314

📥 Commits

Reviewing files that changed from the base of the PR and between 5bcb15a and e08cc65.

📒 Files selected for processing (1)
  • .github/workflows/docs-build.yml

📝 Walkthrough

Walkthrough

The documentation build workflow trigger was modified to use the deploy/faf branch instead of the develop branch, while retaining deployment branches for beta and develop environments. The paths filter and all other workflow logic remain unchanged.

Changes

Cohort / File(s) Summary
Workflow Trigger Configuration
.github/workflows/docs-build.yml
Updated the push event branch filter: removed develop, added deploy/faf, retained deploy/fafdevelop and deploy/fafbeta. Paths filter unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A branch named faf now takes the stage,
While develop bows out from the page,
Docs shall build with swifter grace,
Deploy pipelines find their place! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title references building the website when game files change, but the actual change only modifies documentation build workflow trigger branches without addressing game file detection logic. Update the title to accurately reflect that the change modifies the documentation workflow to trigger on deploy branches instead of develop, e.g., 'Build docs on deploy branches instead of develop'.
Description check ❓ Inconclusive The description explains the problem and proposed solution clearly, but lacks concrete testing details and doesn't follow the template structure with required sections properly filled out. Add a 'Testing done' section documenting how the workflow change was validated, and optionally reference any related issues using the Closes/Fixes format from the template.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch website-deployment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@BlackYps
Copy link
Copy Markdown
Contributor Author

BlackYps commented Apr 11, 2026

Hrm, I just noticed that the workflow (the old workflow file, currently on develop) did not trigger when I deployed to fafdevelop manually. This is strange.

Nevermind, I just forgot to update the staging branch, so no commits were actually deployed.

@Garanas
Copy link
Copy Markdown
Member

Garanas commented Apr 11, 2026

I don't recall why I set it to develop, but in any case deploy/faf should be in that list 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants