Skip to content

Conversation

@ssiccha
Copy link

@ssiccha ssiccha commented Jan 3, 2026

When a player can't connect to a matchmaking game, all players they
can't connect to receive a violation. If the same players re-queue and
are matched again, they easily collect several violations, resulting in
30 min bans.

This should be temporary. The in-development Pioneer ICE Adapter is
better in terms of initial connections. Once it goes into prod we can
revert this. But as we all know, nothing is more permanent than a
temporary solution.

Summary by CodeRabbit

  • Chores
    • Updated ladder violation ban duration configuration settings.

✏️ Tip: You can customize this high-level summary in your review settings.

Brutus5000 and others added 6 commits December 28, 2025 11:21
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
When a player can't connect to a matchmaking game, all players they
can't connect to receive a violation. If the same players re-queue and
are matched again, they easily collect several violations, resulting in
30 min bans.

This should be temporary. The in-development Pioneer ICE Adapter is
better in terms of initial connections. Once it goes into prod we can
revert this. But as we all know, nothing is more permanent than a
temporary solution.
@coderabbitai
Copy link

coderabbitai bot commented Jan 3, 2026

📝 Walkthrough

Walkthrough

A new configuration parameter LADDER_VIOLATIONS_BAN_DURATION with a value of 600 was added to the lobby server configuration file, accompanied by explanatory comments. The existing LADDER_VIOLATIONS_ENABLED parameter remains commented out.

Changes

Cohort / File(s) Summary
Configuration
apps/faf-lobby-server/config/config.yaml
Added LADDER_VIOLATIONS_BAN_DURATION parameter (value: 600) with accompanying documentation comments explaining its purpose and temporary nature

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A config so new, with a comment so clear,
600 seconds of ban, without any fear,
The rabbit hops by with a satisfied grin,
Settings are simple—let the changes begin! ✨

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: setting a ban duration configuration to 10 minutes in the faf-lobby-server config.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a1a4686 and dd9b80a.

📒 Files selected for processing (1)
  • apps/faf-lobby-server/config/config.yaml
🔇 Additional comments (1)
apps/faf-lobby-server/config/config.yaml (1)

48-56: Configuration is valid and well-documented.

The YAML syntax is correct, the value 600 seconds accurately represents 10 minutes, and the comment clearly explains the rationale and temporary nature of the change.

Note: This is a gitops/deployment configuration repository. Verification of whether LADDER_VIOLATIONS_BAN_DURATION is recognized by the lobby server application would require checking the actual application source code in a separate repository. The configuration itself is self-contained and properly documented.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants