-
-
Notifications
You must be signed in to change notification settings - Fork 4
config: faf-lobby-server - Set ban duration to 10 minutes #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
* Update values.yaml * Update deployment.yaml
* Let top players match with anyone in the 1v1 queue
…aunch games Fix faf_data_dir being None
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
When a player can't connect to a matchmaking game, all players they can't connect to receive a violation. If the same players re-queue and are matched again, they easily collect several violations, resulting in 30 min bans. This should be temporary. The in-development Pioneer ICE Adapter is better in terms of initial connections. Once it goes into prod we can revert this. But as we all know, nothing is more permanent than a temporary solution.
📝 WalkthroughWalkthroughA new configuration parameter Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
73e25ff to
86676ce
Compare
When a player can't connect to a matchmaking game, all players they
can't connect to receive a violation. If the same players re-queue and
are matched again, they easily collect several violations, resulting in
30 min bans.
This should be temporary. The in-development Pioneer ICE Adapter is
better in terms of initial connections. Once it goes into prod we can
revert this. But as we all know, nothing is more permanent than a
temporary solution.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.