Skip to content

Conversation

@dennisvang
Copy link
Contributor

@dennisvang dennisvang commented Nov 6, 2025

Basically this is a refactored version of the solution suggested by @qplevier.

Whereas the current implementation picks the first item from the list of targetClassUris, we now check all specified target classes, i.e. both dcat:Resource and its subclasses. As a result, the list of matched subjects is likely to contain duplicates, e.g. one for dcat:Resource and one for dcat:Catalog, but these are removed with the help of Set.

Also added some type specifications, for clarity, and changed the arrow function argument.

fixes #210

Rationale

As far as I can see, the goal in EntityConfig.createChildrenList() is to create a list summarizing all the child resources.
For this reason it needs to obtain all subjects matching the type dcat:Resource or one of its subclasses.

Because the data graph only contains triples describing the child resources, it should be sufficient to grab unique subjects matching any of the target classes defined in the active resource definition.

Notes:

  • The FDP reference implementation specifies both <subject> a dcat:Resource, dcat:Catalog. This seems redundant, knowning that dcat:Catalog is a subclass of dcat:Resource. However, the client is not aware of the DCAT class hierarchy, because there are no explicit rdfs:subClassOf statements in the data graph, and it has not loaded the dcat spec.

@dennisvang dennisvang force-pushed the fix/issue210-missing-catalogs branch from 5c6e934 to 1cba5a8 Compare November 7, 2025 09:40
@dennisvang dennisvang force-pushed the fix/issue210-missing-catalogs branch from 1cba5a8 to f1e333a Compare November 7, 2025 09:46
@dennisvang dennisvang marked this pull request as ready for review November 7, 2025 10:49
@dennisvang dennisvang requested a review from kburger November 7, 2025 10:49
@dennisvang dennisvang force-pushed the fix/issue210-missing-catalogs branch from 2d32630 to d925542 Compare November 7, 2025 15:44
@dennisvang
Copy link
Contributor Author

Thanks for the review @kburger. 🙂
I'll merge this and make a new release.

@dennisvang dennisvang merged commit 2a9e0a4 into support/1.18.x Nov 10, 2025
3 checks passed
@dennisvang dennisvang deleted the fix/issue210-missing-catalogs branch November 10, 2025 11:56
@dennisvang dennisvang changed the title Fix missing children List children based on all targetclasses in schema Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants