forked from nexusformat/definitions
-
Notifications
You must be signed in to change notification settings - Fork 9
Changes from mpes workshop #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,16 +8,21 @@ category: application | |
| NXmpes: | ||
| (NXentry): | ||
| title: | ||
| exists: recommended | ||
| start_time(NX_DATE_TIME): | ||
| doc: "Datetime of the start of the measurement." | ||
| end_time(NX_DATE_TIME): | ||
| exists: recommended | ||
| definition: | ||
| \@version: | ||
| enumeration: ["NXmpes"] | ||
| enumeration: ["NXmpes"] # ISO 18115 | ||
| method: # ISO 18115 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add a proper doc string |
||
| (NXuser): | ||
| doc: "Contact information of at least the user of the instrument or the | ||
| investigator who performed this experiment. | ||
| Adding multiple users if relevant is recommended." | ||
| name: | ||
| exists: recommended | ||
| doc: "Name of the user." | ||
| affiliation: | ||
| exists: recommended | ||
|
|
@@ -28,14 +33,17 @@ NXmpes: | |
| doc: "Full address (street, street number, ZIP, city, country) of the | ||
| user's affiliation." | ||
| email: | ||
| exists: recommended | ||
| doc: "Email address of the user." | ||
| orcid: | ||
| exists: recommended | ||
| doc: "Author ID defined by https://orcid.org/." | ||
| (NXinstrument): | ||
| energy_resolution(NX_FLOAT): | ||
| exist: recommended | ||
| unit: NX_ENERGY | ||
| (NXsource): | ||
| source_beam(NXsource): # TODO: Add linking between source and beam | ||
| # TODO: Much more information possible | ||
| doc: "The source used to generate the primary photons. Properties refer strictly to parameters of the source, not of the output beam. | ||
| For example, the energy of the source is not the optical power of the beam, but the energy of the electron beam in a synchrotron and so on." | ||
| type: | ||
|
|
@@ -48,13 +56,22 @@ NXmpes: | |
| "Optical Laser", | ||
| "UV Plasma Source", | ||
| "Metal Jet X-ray", | ||
| "HHG laser" | ||
| "HHG laser", | ||
| "UV lamp", | ||
| "other" | ||
| ] | ||
| type_other: | ||
| exists: optional | ||
| doc: Specification of type, may also go to name | ||
| # TODO: | ||
| name: | ||
| exists: recommended | ||
| probe: | ||
| doc: "Type of probe. In photoemission it's always photons, so the full NIAC list is restricted." | ||
| enumeration: ["x-ray","ultraviolet", "visible light"] | ||
| (NXbeam): | ||
| doc: | | ||
| Type of probe. In photoemission it's always photons, so the full NIAC list is restricted" | ||
| enumeration: ["photons"] | ||
| beam_probe(NXbeam): # TODO: Add linking between source and beam | ||
| # TODO: Maybe add extend as recommended | ||
| distance(NX_NUMBER): | ||
| doc: "Distance of the point of evaluation of the beam from the sample surface." | ||
| unit: NX_LENGTH | ||
|
|
@@ -67,7 +84,8 @@ NXmpes: | |
| exists: recommended | ||
| unit: NX_ANY | ||
| (NXelectronanalyser): | ||
| description: | ||
| model(NXfabrication): | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe manufacturer, model, and serial number could be recommended here. |
||
| exists: recommended | ||
| energy_resolution(NX_FLOAT): | ||
| exists: recommended | ||
| doc: "Energy resolution of the analyser with the current setting. May be linked from a NXcalibration." | ||
|
|
@@ -160,6 +178,7 @@ NXmpes: | |
| calibrated_axis(NX_FLOAT): | ||
| exists: recommended | ||
| doc: "This is the calibrated energy axis to be used for data plotting." | ||
| # TODO: | ||
| angular_calibration(NXcalibration): | ||
| exists: optional | ||
| applied(NX_BOOLEAN): | ||
|
|
@@ -223,6 +242,7 @@ NXmpes: | |
| # Similar situation here, ca be a single number or a log. | ||
| gas_pressure(NX_FLOAT): | ||
| unit: NX_PRESSURE | ||
| (NXtransformations): # TODO: Add this here? | ||
| (NXdata): | ||
| \@signal: | ||
| enumeration: ["data"] # There is an object named data that contains the signal | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see also my comments in the NXmpes_xps PR:
#30 (comment)