Merged
Conversation
…ntangling of min_incr_max for subsampling filter to offer searchability in RDM systems
…ntage of application definition inheritance for config
… inheritance and base class inheritance
…ng paraview/xdmf is used
lukaspie
reviewed
Oct 16, 2025
lukaspie
reviewed
Oct 16, 2025
lukaspie
reviewed
Oct 16, 2025
lukaspie
reviewed
Oct 16, 2025
… modulus and thermal lattice expansion
lukaspie
approved these changes
Nov 11, 2025
Collaborator
lukaspie
left a comment
lukaspie
left a comment
There was a problem hiding this comment.
I can't really comment on the science, but NeXus-wise, it looks fine. Small comment, but nothing that prevents merging.
Collaborator
Author
|
Thank you very much @lukaspie for your feedback and review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review But do not merge this!