Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings in the application definition and base classes from the XraySpectroscopy working group (see their full set of changes).
I intentionally placed these files in
contributed_definitionssince they are still in a working state. There's not a concrete timeline for standardizing with the NIAC.We have to think if we want to include these classes in the definitions of pynxtools. It is a requisite for
pynxtools-xasto work, but it may be confusing for people who are not familiar with the context around these developments.This also updates the custom dict for spellchecking. I ran a similar script to the one in pynxtools to generate the custom dict. This removes the artificial order that we had before (hence the large amount of changes), but I think that is worth it since we then don't need to tediously modify this file per hand.
cc @mkuehbach