Conversation
* Updates NXtransformations docs * Manually set to lower case true * Do a forward-backward nyaml cycle for NXtransformations # Conflicts: # base_classes/nyaml/NXtransformations.yaml
# Conflicts: # base_classes/nyaml/NXtransformations.yaml
# Conflicts: # base_classes/nyaml/NXtransformations.yaml
# Conflicts: # base_classes/NXtransformations.nxdl.xml # base_classes/nyaml/NXtransformations.yaml
Co-authored-by: Peter Chang <peter.chang@diamond.ac.uk>
Also removes the minOccurs and maxOccurs values, which are redundant for an object with nameType="any"
This is meant to correct the impression that this base class is predominantly meant for fitting.
…e fitting parameters.
For the following reasons: i) model is also a parameter, cuz it can be used to instruct programs to follow specific execution branches ii) currently the NeXus documentation building as issues with dealing with groups where an attribute and field with the same concept name appear, see conversation of the nexusformat#1560 for more details about this, what I think is a bug.
Co-authored-by: Lukas Pielsticker <50139597+lukaspie@users.noreply.github.com> Co-authored-by: markus.kuehbach <markus.kuehbach@hu-berlin.de> Co-authored-by: Markus Kühbach <mkuehbach@users.noreply.github.com> Co-authored-by: RubelMozumder <32923026+RubelMozumder@users.noreply.github.com> Co-authored-by: Rubel <rubel.mozumder@outlook.com> Co-authored-by: domna <florian.dobener@physik.hu-berlin.de> Co-authored-by: Florian Dobener <florian.dobener@physik.hu-berlin.de> Co-authored-by: kuehbachm <kuehbacm@hu-berlin.de> Co-authored-by: mkuehbach <markus.kuehbach@physik.hu-berlin.de> Co-authored-by: Pete R Jemian <prjemian@gmail.com> Co-authored-by: RubelMozumder <rubelmozumder@outlook.com> Co-authored-by: Sherjeel Shabih <shabihsherjeel@gmail.com> Co-authored-by: lukaspie <lukaspie@github.com>
lukaspie
changed the title
Also update expected subdirectories and fix script to filter out cache
Remove commented out section in cantilever base class
Some files may have existed elsewhere before being committed to this repo
lukaspie
changed the title
mkuehbach
left a comment
mkuehbach
left a comment
There was a problem hiding this comment.
overall looks good, some changes of start time, would be good to check if these come from PRs, I can support you with checking these
.cspell/custom-dictionary.txt
Outdated
| voronoi | ||
|
|
||
| # Software | ||
| # Sofstware |
There was a problem hiding this comment.
this should be fixed if needed in the places where it occurs, FAIRmat release always should be better spellchecking wise than the official release, to motivate edits in the official, no commented out text in this file except maybe the header line
There was a problem hiding this comment.
For this repo, we are still manually putting the additional words into this dictionary, sorted by where they come from (#NeXus, #Software, etc...). This is our manual comment here, it is not used anywhere in the actual files.
We could have an automated script (like in pynxtools that atuo-generates this files. Then these comments would go away, but for now, let's keep them.
For some reason a typo was introduced, I reverted this now.
9 participants
Squash merge, brings NIAC official patch v2026.01 patch release, many changes caused by the patch release updated end year in the copyright part of the definitions.
The patch release includes SPM so this PR likely superseeds #404