Add new application definition for PEEM experiments#65
Add new application definition for PEEM experiments#65PeterC-DLS wants to merge 8 commits intoFAIRmat-NFDI:mpes-refactorfrom
Conversation
domna
left a comment
There was a problem hiding this comment.
Hey @PeterC-DLS,
thank you for your proposal. I left some comments in the yaml file.
This extends NXmpes and adds some new groups and fields and also adjusts some existing fields' classes
Move YAML to nyaml directory, tweak PEEM definition according to feedback, push some changes to base MPES definition and add some units
a5b79a4 to
92dfde8
Compare
3de0d91 to
13e2251
Compare
|
Hey @PeterC-DLS, I just wanted to let you know that we started to add an additional level on top of NXmpes: NXphotoemission. See #74 for further details. Other than this: Can I help you with anything to finalise this PR? Are there currently any open points/blockers for you? |
|
Thanks for the update and pointer. Your PR sounds fine to me. |
Sure and thanks. |
|
I will update and rebase this PR once you have finalized or merged your refactor of NXmpes to NXphotoemission. |
|
@PeterC-DLS I think this auto closed due to our merge of We did not yet add the top-level class |
|
I have just rebase this to the old branch! But it's not a problem for me to rebase as and when |
This extends NXmpes and adds some new groups and fields and also adjusts some existing fields' classes