Skip to content

documentation#186

Draft
EBB2675 wants to merge 1 commit intodevelopfrom
documentation
Draft

documentation#186
EBB2675 wants to merge 1 commit intodevelopfrom
documentation

Conversation

@EBB2675
Copy link
Collaborator

@EBB2675 EBB2675 commented May 9, 2025

No description provided.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the chapters "Hierarchical ModelSystems" and "Normalization Workflow" best, since they give me an idea of what this tool models, how to use it, and what it means to normalize it. I'd actually prefer them more fleshed out.

Conversely, these tables should probably be listed in a reference.md. They can also be automatically generated, e.g. via

plugins:
  - mkdocstrings:
      handlers:
        python:
          options:
            show_docstring_attributes: true
            docstring_section_style: table

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was clear here that these can be later on.
Wouldn't forget the references, though. Especially given the amount of information in the pydocs that @EBB2675 added.

@JFRudzinski
Copy link
Collaborator

I would like to merge as much work as possible before next week. I see no reason why this can't be simply merged. If these review notes are still relevant, I would suggest opening an issue that points to these and then merging this PR

@JFRudzinski JFRudzinski mentioned this pull request Dec 19, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants