using readonly instead of user_editability; enabling injesting multip…#486
Merged
using readonly instead of user_editability; enabling injesting multip…#486
Conversation
…le methods to the base classes and not only the normalization; Entry to inherit also from Task, so Workflow click drives there directly
…sation from Measurement and Activity
lukaspie
previously requested changes
Dec 19, 2024
Collaborator
lukaspie
left a comment
lukaspie
left a comment
There was a problem hiding this comment.
We should definitely also think how we can keep this clean and maintainable in the future. Maybe we can separate the actual schema creation a bit from the definition of new base section classes and normalization functions (i.e, move these to a new python file in the future)
…er ELN normalisation
sanbrock
commented
Jan 8, 2025
sanbrock
commented
Jan 8, 2025
sanbrock
commented
Jan 8, 2025
RubelMozumder
approved these changes
Jan 8, 2025
Collaborator
RubelMozumder
left a comment
RubelMozumder
left a comment
There was a problem hiding this comment.
I tested both features of regenerating the existing nexus entry and workflow steps. LGTM!
sanbrock
dismissed
lukaspie’s stale review
requested modifications are implemented
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…le methods to the base classes and not only the normalization; Entry to inherit also from Task, so Workflow click drives there directly