Merged
Conversation
0f7b54a to
01cff25
Compare
mkuehbach
reviewed
Jan 13, 2025
Collaborator
There was a problem hiding this comment.
Technically the changes look good to me.
I was not aware though that such new logo at all exists, we should maybe ask the management if we ought
are allowed to use that logo for pynxtools (and all of its FAIRmat-maintained pynxtools-plugins),
i.e. what is the usage policy when software tools are official NOMAD plugins to qualify for such logo?
If we get the green light from the management, sure merge this in. Thank you.
Collaborator
Author
These are the logos that are used by all of the NOMAD plugins that are generated from the template (see here), so I think it's safe to say we can use them. |
a604648 to
397add9
Compare
397add9 to
f58dcc6
Compare
This was referenced Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mkuehbach the new docs would look like this, is this what you wanted? Clicking on that icon also just brings you back to the home page of the docs now.

I also added a navigation in the footer and changed the favicon to the nomad plugins logo.