Conversation
2f2d5a7 to
0a8d199
Compare
lukaspie
commented
Aug 8, 2025
6a5d057 to
96c6f8c
Compare
…ing custom attribute
da0bddf to
141979a
Compare
lukaspie
commented
Oct 1, 2025
Collaborator
RubelMozumder
left a comment
There was a problem hiding this comment.
I left a few questions.
RubelMozumder
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #666
Implementation is the following:
@customattribute (or@my_attribute_customattribute for a a given attributemy_attribute).@customis set to False.@customattribute is missing, a warning is logged.@customattribute is missing, we add it automatically to the template. As the produced file is then correct, we only log an info message (incl. the information that the attribute was added automatically).Further changes:
ignore_sections = {"FIELD (//Ag__002__VB/start_time)": ["DEBUG - value:"]}and this will also ignore the"DEBUG - value:"line in all sections that start with"FIELD (//Ag__002__VB/start_time). We need this as for fields the line is actuallyDEBUG - ===== FIELD (//Ag__002__VB/start_time): <HDF5 dataset "start_time": shape (), type "|O">and I don't want people having to give the whole line including the dataset information.