Merged
Conversation
11 tasks
lukaspie
force-pushed
the
716-spellchecking-should-include-the-source-code-as-well
branch
from
6956f85 to
edf50a0
Compare
mkuehbach
requested changes
Nov 12, 2025
Collaborator
mkuehbach
left a comment
mkuehbach
left a comment
There was a problem hiding this comment.
A few comments to clarify, otherwise reasonable.
Co-authored-by: Markus Kühbach <mkuehbach@users.noreply.github.com>
lukaspie
force-pushed
the
716-spellchecking-should-include-the-source-code-as-well
branch
from
9097307 to
16268b1
Compare
mkuehbach
requested changes
Nov 12, 2025
Collaborator
mkuehbach
left a comment
mkuehbach
left a comment
There was a problem hiding this comment.
Regenerating the custom dictionary remains, otherwise this is ready.
Collaborator
Author
Done, doesn't really remove too much though. Anyway, should be good to go then here. |
rettigl
approved these changes
Nov 13, 2025
Collaborator
rettigl
left a comment
rettigl
left a comment
There was a problem hiding this comment.
LGTM, after fixing and removing a few items from the custom dict.
mkuehbach
approved these changes
Nov 13, 2025
Collaborator
mkuehbach
left a comment
mkuehbach
left a comment
There was a problem hiding this comment.
Comments were addressed professionally.
lukaspie
deleted the
716-spellchecking-should-include-the-source-code-as-well
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pynxtools-plugin-template.This requires a fix for the Metainfo schema (6956f85), where we had a missspelling before and thus the method was never used.