Conversation
…nly those modifications pertaining to customized chunking related work, and adding the customize auto chunker code snippet from pynxtools-em and pynxtools-apm here, next step copy over the documentation from the refactoring_compression feature branch and add to that existent documentation details about what this feature branch adds as additional functionalities for customizing the chunking
I could add a test_chunk.py probing the return values of some instances of custom auto chunker |
Tests added |
lukaspie
left a comment
There was a problem hiding this comment.
Mostly good, just one additional comment. Thanks!
| @@ -0,0 +1,57 @@ | |||
| # | |||
There was a problem hiding this comment.
These three new files should be combined into one (e.g. chunk.py) since they all address the same functionality.
Alternatively, as discussed in #739, they should go to helpers.py.
| ) -> tuple[int, ...] | bool: | ||
| """Define an explicit tuple[int] how to chunk data with shape | ||
|
|
||
| Parameter: |
There was a problem hiding this comment.
This is a very large docstring, maybe we can have a link in the docs to this file to explain why/how the heuristic is different here.
Motivation: