Skip to content

Generate selection urls#33

Merged
prakhyatox merged 12 commits intodevfrom
generate-selection-URLS
Oct 10, 2025
Merged

Generate selection urls#33
prakhyatox merged 12 commits intodevfrom
generate-selection-URLS

Conversation

@prakhyatox
Copy link
Contributor

Ticket: #25

@netlify
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for fairassist-app ready!

Name Link
🔨 Latest commit 6289a2d
🔍 Latest deploy log https://app.netlify.com/projects/fairassist-app/deploys/68e7e3a5af4cd40008493843
😎 Deploy Preview https://deploy-preview-33--fairassist-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@allysonlister allysonlister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, though I have noticed one thing: This page below is for https://deploy-preview-33--fairassist-app.netlify.app/registry?search=(principle=The+FAIR+Principles%26objectTypes=terminology_artifact%26toolNames=FOOPS!%26recordType=metric_ids) - when it is opened in a new page the functionality is correct but the 'terminology artifact' is not pre-selected within that pulldown menu as one sees for the other two values that have been selected.
image

Please can you check that all pulldown options are visible in the chips/breadcrumbs and in the pulldowns themselves for each of the fields?

As an aside, the object types pulldown doesn't appear to have any inherent ordering. If it's easy to eg provide alphabetical ordering this would help in finding the object types one is looking for.

Thanks!

@prakhyatox
Copy link
Contributor Author

Looking good, though I have noticed one thing: This page below is for https://deploy-preview-33--fairassist-app.netlify.app/registry?search=(principle=The+FAIR+Principles%26objectTypes=terminology_artifact%26toolNames=FOOPS!%26recordType=metric_ids) - when it is opened in a new page the functionality is correct but the 'terminology artifact' is not pre-selected within that pulldown menu as one sees for the other two values that have been selected. image

Please can you check that all pulldown options are visible in the chips/breadcrumbs and in the pulldowns themselves for each of the fields?

As an aside, the object types pulldown doesn't appear to have any inherent ordering. If it's easy to eg provide alphabetical ordering this would help in finding the object types one is looking for.

Thanks!

Fixed

Copy link

@allysonlister allysonlister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - looks good!

@codacy-production
Copy link

codacy-production bot commented Oct 9, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b98a37b) 2348 2348 100.00%
Head commit (6289a2d) 2619 (+271) 2619 (+271) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#33) 556 556 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@prakhyatox prakhyatox merged commit 34423ba into dev Oct 10, 2025
14 checks passed
@prakhyatox prakhyatox deleted the generate-selection-URLS branch October 10, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants