Adding code to reset the results if principle selection is changed#37
Adding code to reset the results if principle selection is changed#37prakhyatox merged 2 commits intodevfrom
Conversation
✅ Deploy Preview for fairassist-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I guess you could use something like: "Changing between FAIR and FAIR4RS principles will clear your search results. Proceed Y/N?" |
allysonlister
left a comment
There was a problem hiding this comment.
Looking great, all functioning as expected other than one thing:
Screencast From 2025-10-14 11-02-21.webm
Here, if all I have chosen is "Metric" and I reset the type of principles, the apply filter is still inactive. On one level this makes sense as you need to reset 'apply filter' when the principles have changed.
However, shouldn't one of two things occur at this stage (either behaviour is fine with me):
- either the 'metric' option should also be cleared, or
- apply filter should be active / possible to be pressed, because metric is the only thing chosen and would be valid for either principle set.
|
I am not able to check the video here. Could you please share on zulip |
|
It works fine when I tried on netlify. If possible could you please try once again in incognito? FAIRassist.webm |
|
perhaps try to do it multiple times in a row? InPrivate tab first time: Then, just as a second video but continuing directly from the first: |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Ticket: #36
Please share the text for the warning popup.
If Apply filter button is not clicked and user wants to change the principle selection there won't be any popup, as it does not make any sense.
If Apply Filter button is clicked there will be selection, if the user then wants to change the principle selection user will encounter popup with warning that everything will be reset and if selection is changed