Skip to content

Adding code to reset the results if principle selection is changed#37

Merged
prakhyatox merged 2 commits intodevfrom
reset-results-and-filters-36
Oct 15, 2025
Merged

Adding code to reset the results if principle selection is changed#37
prakhyatox merged 2 commits intodevfrom
reset-results-and-filters-36

Conversation

@prakhyatox
Copy link
Contributor

@prakhyatox prakhyatox commented Oct 14, 2025

Ticket: #36
Please share the text for the warning popup.

  1. If Apply filter button is not clicked and user wants to change the principle selection there won't be any popup, as it does not make any sense.

  2. If Apply Filter button is clicked there will be selection, if the user then wants to change the principle selection user will encounter popup with warning that everything will be reset and if selection is changed

@netlify
Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for fairassist-app ready!

Name Link
🔨 Latest commit 08df94e
🔍 Latest deploy log https://app.netlify.com/projects/fairassist-app/deploys/68ee5e4663257800087b917b
😎 Deploy Preview https://deploy-preview-37--fairassist-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@prakhyatox prakhyatox added the enhancement New feature or request label Oct 14, 2025
@prakhyatox prakhyatox requested a review from knirirr October 14, 2025 09:09
@knirirr
Copy link
Contributor

knirirr commented Oct 14, 2025

I guess you could use something like:

"Changing between FAIR and FAIR4RS principles will clear your search results. Proceed Y/N?"

Copy link

@allysonlister allysonlister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, all functioning as expected other than one thing:
Screencast From 2025-10-14 11-02-21.webm

Here, if all I have chosen is "Metric" and I reset the type of principles, the apply filter is still inactive. On one level this makes sense as you need to reset 'apply filter' when the principles have changed.

However, shouldn't one of two things occur at this stage (either behaviour is fine with me):

  1. either the 'metric' option should also be cleared, or
  2. apply filter should be active / possible to be pressed, because metric is the only thing chosen and would be valid for either principle set.

@prakhyatox
Copy link
Contributor Author

I am not able to check the video here. Could you please share on zulip

@prakhyatox
Copy link
Contributor Author

It works fine when I tried on netlify. If possible could you please try once again in incognito?

FAIRassist.webm

@allysonlister
Copy link

perhaps try to do it multiple times in a row?

InPrivate tab first time:
Screencast From 2025-10-14 14-04-40.webm

Then, just as a second video but continuing directly from the first:
Screencast From 2025-10-14 14-05-07.webm

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (34423ba) 2619 2619 100.00%
Head commit (08df94e) 2749 (+130) 2749 (+130) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#37) 155 155 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

@allysonlister allysonlister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well thank you!

@prakhyatox prakhyatox merged commit 3c913b7 into dev Oct 15, 2025
14 checks passed
@prakhyatox prakhyatox deleted the reset-results-and-filters-36 branch October 15, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants