Skip to content

Conversation

@shnizzedy
Copy link
Member

Related to

Related to #2100 by @sgiavasis

Description

Reverts two file mode 644 → 755 changes from the 1.8.7 development cycle.

Technical details

As of ff57b3f, 3 files have their modes changed from rw-r--r-- to rwxr-xr-x.

CPAC/utils/configuration/yaml_template.py has

if __name__ == '__main__':
update_all_preconfigs()
and was made executable in #2072 for pre-commit to execute that script.

The other two files don't have if __name__ == "__main__": fences or any top-level code besides imports and definitions, so I think the additional executable mode change was in error and is reverted here.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy self-assigned this May 2, 2024
@shnizzedy shnizzedy requested a review from a team May 2, 2024 15:13
@shnizzedy shnizzedy added the develop issue on `develop` branch label May 2, 2024
@shnizzedy shnizzedy added this to the 1.8.7 release milestone May 2, 2024
@shnizzedy shnizzedy mentioned this pull request May 2, 2024
@sgiavasis sgiavasis merged commit 9b437c3 into develop May 3, 2024
sgiavasis added a commit that referenced this pull request May 3, 2024
Update release candidate with recent PR #2101 to `develop`
@shnizzedy shnizzedy deleted the chmod/1.8.7 branch July 3, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

develop issue on `develop` branch

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants