➖ removed extra unused outputs from the list

[birajstha]

Fixes

Fixes #[issue number] by @[original issue author]
These additional code is causing no harm but may create un-necessary confusion. It may create wrong information in the tools that depends on this like blockbuster and resource-inventory. They are probably remains from refactoring of the code before and is safe to remove.

Description

Removed extra unused outputs from the list of freesurfer_abcd_preproc nodeblock outputs.

Technical details

These extra outputs are listed in the decorator as outputs but, the nodeblock does not output these resources.

These resources are generated from freesurfer ingress or from recon_all here and here.

Tests

Screenshots

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the develop branch of the repository.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I updated the changelog.
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[shnizzedy]

I think this is probably the right approach, but alternatively we could add these outputs to cpac_outputs.tsv and to the outputs that the NodeBlock actually outputs. I don't know how many loose files from a recon-all run are useful though, and we can just recommend running FreeSurfer separately before running C-PAC for users that want all the FreeSurfer outputs.