Skip to content

Comments

👷 Set permissions on GitHub Actions workflows#2216

Merged
shnizzedy merged 12 commits intodevelopfrom
security/code-scanning-alerts
Apr 30, 2025
Merged

👷 Set permissions on GitHub Actions workflows#2216
shnizzedy merged 12 commits intodevelopfrom
security/code-scanning-alerts

Conversation

@shnizzedy
Copy link
Member

Fixes

Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/4 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/7 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/11 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/13 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/15 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/16 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/17 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/18 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/19 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/20 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/21 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/22 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/23 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/24 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/25 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/26 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/1 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/2 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/3 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/5 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/6 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/8 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/9 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/10 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/12 by @CodeQL
Fixes https://github.com/FCP-INDI/C-PAC/security/code-scanning/14 by @CodeQL
Fixes #1903 by @amygutierrez

Description

  • Sets permissions1 for GitHub Actions workflows in this repository.
  • Fixes broken .github/workflows/delete_images.yml while we're updating the workflows.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Footnotes

  1. GitHub, Inc. "GitHub Actions: Control permissions for GITHUB_TOKEN." :octocat:/Blog (2021-04-20).

@shnizzedy shnizzedy requested a review from a team April 17, 2025 16:31
@shnizzedy shnizzedy self-assigned this Apr 17, 2025
@shnizzedy shnizzedy moved this to 👀 In review in C-PAC Development Apr 17, 2025
@shnizzedy shnizzedy added this to the 1.8.8 release milestone Apr 17, 2025
Copy link
Contributor

@birajstha birajstha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.2%. Comparing base (801a5e8) to head (ef62f12).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2216   +/-   ##
=======================================
  Coverage     27.2%   27.2%           
=======================================
  Files          228     228           
  Lines        25830   25830           
  Branches      4062    4062           
=======================================
  Hits          7025    7025           
  Misses       18188   18188           
  Partials       617     617           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shnizzedy shnizzedy merged commit 9248007 into develop Apr 30, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in C-PAC Development Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants