Skip to content

HEA-572 Add field-level checks to xxx_valid_instances #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 22, 2024
Merged

HEA-572 Add field-level checks to xxx_valid_instances #131

merged 3 commits into from
Nov 22, 2024

Conversation

@rhunwicks
Copy link
Contributor

@rhunwicks rhunwicks commented Nov 22, 2024

No description provided.

@rhunwicks rhunwicks requested a review from girumb November 22, 2024 03:45
@rhunwicks rhunwicks self-assigned this Nov 22, 2024
@rhunwicks
Copy link
Contributor Author

rhunwicks commented Nov 22, 2024

@girumb please can you check this and then if you agree, merge it and release it to dev and rerun all xxx_instances and xxx_valid_instances. Then @h-kiros can review the output and start adding corrections to the GSheet for any BSS where we have negative kcals_consumed.

@rhunwicks
Copy link
Contributor Author

rhunwicks commented Nov 22, 2024

@h-kiros for the BSSs where we have negative kcals_consumed and percentage_kcals you will need to adjust the quantity_other_uses so that quantity_other_uses = quantity_produced - quantity_sold

@girumb girumb merged commit bd9f36f into main Nov 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@girumb girumb girumb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rhunwicks rhunwicks

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhunwicks @girumb