Skip to content

Add coverstion to numeric value before the aggregates #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
Merged

Add coverstion to numeric value before the aggregates #184

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3325abf
Add coverstion to numeric value before the aggregates have been appli…
girumb Oct 17, 2025
3de3466
Update numeric conversion to fill NaN with 0 - see HEA-780
rhunwicks Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pipelines/assets/livelihood_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1337,6 +1337,9 @@ def get_annotated_instances_from_dataframe(
# Annotate the output metadata with completeness information
# Get the summary dataframe, grouped by strategy_type
summary_df = pd.DataFrame(reported_summary_output.value["LivelihoodActivity"])
for col in ["income", "expenditure", "kcals_consumed"]:
summary_df[col] = pd.to_numeric(summary_df[col], errors="coerce")

Copy link
Contributor

@rhunwicks rhunwicks Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@girum-air Do we need to add .fillna(0) so that groupby().sum() below doesn't return nan?

summary_df = (
summary_df[["strategy_type", "income", "expenditure", "kcals_consumed"]].groupby("strategy_type").sum()
)
Expand Down