FEXCore: use ankerl::unordered_dense over tsl #5162
+10
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
dep: #5163 |
This was referenced Dec 28, 2025
Member
|
In order to limit the potential fallout from this change. I would prefer if only tsl gets replaced with ankerl and leave the std implementation alone. |
crueter
force-pushed
the
unordered-dense
branch
from
a0c0772 to
508d3c2
Compare
crueter
changed the title
crueter
force-pushed
the
unordered-dense
branch
from
508d3c2 to
226f3e5
Compare
Contributor
Author
|
done. Interestingly |
Member
The fextl stuff is grown organically as we hit std containers that need wrapping with allocators. So it was likely used before and removed, or I overreached while implementing. Doesn't really matter, it'll sit around and be used if someone needs it. |
ankerl::unordered_dense is faster on average and has less memory usage than tsl::robin_map. It is pretty significantly faster than std but we'll keep that as is for now. Obviously, this will need a lot of testing. Signed-off-by: crueter <[email protected]>
crueter
force-pushed
the
unordered-dense
branch
from
226f3e5 to
0ef6faa
Compare
crueter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ankerl::unordered_dense is faster on average and has less memory usage
than both std::unordered_map and tsl::robin_map. It's also seemingly
better maintained, and shouldn't need an extra patch on top of upstream--this has the added benefit of allowing users to use the system unordered_dense package, which I'm sure the Gentoo packagers will appreciate. Plus it will complement #5159 nicely :)
Obviously, this will need a lot of testing.
Signed-off-by: crueter [email protected]