Fix duplicate CI runs #817
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Are you sure you want to do this? A person might push several commits to a branch before opening a PR, and they would not have any CI until they open a PR. |
Contributor
Author
|
The amount of redundant work we perform is quite massive atm. The real fix would be to run either pull request or on push but that is not possible with GitHub actions https://github.com/orgs/community/discussions/26276. On a branch one can always comment out the single line https://github.com/FEniCS/ffcx/pull/817/changes#diff-cbf97851bdfebccf2fcdd8848c6a93adb8d8affd5c6b1faf00238d528c3ef6cbR10 to reactivate on push CIs or trigger through a workflow. Both really not nice options, but I would say preferable to running both on every PR push. In DOLFINx we do the same to avoid duplicate runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs currently run duplicate CI runs, once triggered through the
pushand once through thepull_requestevent.main.