Handle finding IG URLs for release-specific packages with incorrect packageIds#1614
Merged
Handle finding IG URLs for release-specific packages with incorrect packageIds#1614
Conversation
jduteau
approved these changes
Mar 8, 2026
Collaborator
jduteau
left a comment
jduteau
left a comment
There was a problem hiding this comment.
This looks good to me and I tested it out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Some release-specific packages (e.g., hl7.fhir.eu.extensions.r4) don't include the correct packageId in their
ImplementationGuideresource; they might have a packageId likehl7.fhir.eu.extensions.4.0.1. Update the IG Exporter to handle this case so it can still find the correct IG URL for affected release-specific package dependencies.Testing Instructions: Unit tests demonstrate the fix. You can also try setting up a simple SUSHI project with
hl7.fhir.eu.extensions.r4as a dependency. The currently released SUSHI will export an IG with the dependency's URL ashttp://hl7.eu/fhir/extensions. This PR branch will export an IG with the dependency's URL ashttp://hl7.eu/fhir/extensions/ImplementationGuide/hl7.fhir.eu.extensions(which is correct).Related Issue: https://chat.fhir.org/#narrow/channel/215610-shorthand/topic/ImplementationGuide.20URL.20missing/near/576162330