Fix building mappings in snapshot mode when parent has no mappings#1618
Open
Fix building mappings in snapshot mode when parent has no mappings#1618
Conversation
In the case that an originalMapping is empty ([]), it might get cleaned and deleted. Usually this is ok, but when building snapshots, we reference it to build the mapping, so we need to treat an undefined originalMapping like [] if that occasion arises. Fixes #1616
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: If a parent SD has no mappings, then
StructureDefinition.originalMappingwill be empty (e.g.,[]). During export, SDs are "cleaned" and properties that are empty arrays are deleted (since empty arrays are not allowed in FHIR). WhenoriginalMappingwas deleted, however, the code that builds the mappings in snapshot mode crashes trying to dereferenceoriginalMapping. Now an undefinedoriginalMappingwill be treated as an empty array (which is what it was before cleaning).Testing Instructions: You can reproduce this using the project from #1616:
On
masterit will crash but on this PR branch the build will succeed.Related Issue: #1616