remove iframe to fix keyboard tab trap.#332
Merged
acharraggi merged 2 commits intoFIRST-Tech-Challenge:mainfrom Jan 16, 2025
Merged
remove iframe to fix keyboard tab trap.#332acharraggi merged 2 commits intoFIRST-Tech-Challenge:mainfrom
acharraggi merged 2 commits intoFIRST-Tech-Challenge:mainfrom
Conversation
texasdiaz
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace with a PDF 'gateway' section and button link.
This is a fix to and accessibility issue: when tabbing through the current page focus is trapped in the iframe and cannot escape.
The replace the iframe with a "gateway page" which summarizes the PDF and let's the user decide if they want to take the trouble to view or download it. The link is styled as a button to ensure it is distinct from regular links. It also has text indicating the link is to a PDF, the file size, and that the link will open in a new tab. These are all accessibility features.
Here's what this will look like:
