New base image for a new version of kjson#1901
Merged
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
Mintaka uses Testcontainers 1.15.1 (Docker API v1.30) but the ubuntu-latest runner now requires API v1.44+. Patch pom.xml to use Testcontainers 1.19.3 before running tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Docker 29 requires API v1.44+. Testcontainers < 1.21.3 defaults to older API versions. 1.19.3 was still too old (API v1.32). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Testcontainers 1.21.3 still uses docker-java with API v1.32. Docker 29+ requires v1.44+. Setting api.version explicitly in docker-java.properties is the recommended workaround. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add withStartupTimeout(5 min) to ComposeTest.java via sed patch, add Duration/ChronoUnit imports, configure testcontainers for local docker compose, and fix properties file whitespace. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
orion-ld container is crashing silently and testcontainers cleans up before we can see the logs. Add a pre-test step that runs the compose stack independently, captures container logs, and shows why orion-ld fails to start. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The smoke test proved orion-ld starts fine but likely caused port conflicts for the subsequent Testcontainers run. Also removed ~/.testcontainers.properties and TESTCONTAINERS_DOCKER_COMPOSE_LOCAL overrides - Testcontainers 1.21.3 with File constructor already defaults to local compose. Added docker events to failure diagnostics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New base image as a bug has been fixed in kjson - it's release number has changed.
I modified also the functest (needed) but, it's going to fail here as the old base image is used during tests.
Pity but, not a problem