Skip to content

Conversation

@nathandud
Copy link

Proposed fix to #621. A realm database table opens as expected when this NSParameterAssert is removed.

@NSExceptional
Copy link
Collaborator

Can you see if just removing the && !databaseManager from the none condition part fixes it? I still want to keep the assertion, it just needs to be correct

@NSExceptional NSExceptional added the awaiting response … from the author, to proceed label Sep 26, 2022
@lubelio
Copy link

lubelio commented Dec 9, 2022

rowIDs:(nullable NSArray<NSString *> *)rowIDs

Can you see if just removing the && !databaseManager from the none condition part fixes it? I still want to keep the assertion, it just needs to be correct

It only works if removing rowIDs and !rowIDs from both all and none conditions

capecrawler pushed a commit to capecrawler/FLEX that referenced this pull request Jun 5, 2023
@NSExceptional
Copy link
Collaborator

@lubelio the original issue states:

When opening up a SQLLite database table, the databaseManager points to null (and so do rowIDs and tableName) and the none condition is satisfied. However when trying to open a Realm database table, the databaseManager object pointer is not null and the assert fails. When I remove that assert, the code works as expected and I can view a Realm database.

If this is accurate, then simply removing the databaseManager from each check would suffice. The resulting condition would be:

!rowIDs && !tableName &&

And this would satisfy Realm, since those are both still nil. Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting response … from the author, to proceed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants