Merge pull request gothinkster#53 from foopang/fix-warnings

EricSimons · web-flow · commit 16e498f34b6c · 2017-05-02T21:05:03.000-07:00
Fix warnings
diff --git a/src/agent.js b/src/agent.js
@@ -1,5 +1,3 @@
-'use strict';
-
 import superagentPromise from 'superagent-promise';
 import _superagent from 'superagent';
 
diff --git a/src/components/Article/ArticleMeta.js b/src/components/Article/ArticleMeta.js
@@ -7,7 +7,7 @@ const ArticleMeta = props => {
   return (
     <div className="article-meta">
       <Link to={`@${article.author.username}`}>
-        <img src={article.author.image} />
+        <img src={article.author.image} alt={article.author.username} />
       </Link>
 
       <div className="info">
diff --git a/src/components/Article/Comment.js b/src/components/Article/Comment.js
@@ -15,7 +15,7 @@ const Comment = props => {
         <Link
           to={`@${comment.author.username}`}
           className="comment-author">
-          <img src={comment.author.image} className="comment-author-img" />
+          <img src={comment.author.image} className="comment-author-img" alt={comment.author.username} />
         </Link>
         &nbsp;
         <Link
diff --git a/src/components/Article/CommentInput.js b/src/components/Article/CommentInput.js
@@ -42,7 +42,8 @@ class CommentInput extends React.Component {
         <div className="card-footer">
           <img
             src={this.props.currentUser.image}
-            className="comment-author-img" />
+            className="comment-author-img"
+            alt={this.props.currentUser.username} />
           <button
             className="btn btn-sm btn-primary"
             type="submit">
diff --git a/src/components/Article/index.js b/src/components/Article/index.js
@@ -1,8 +1,5 @@
-'use strict';
-
 import ArticleMeta from './ArticleMeta';
 import CommentContainer from './CommentContainer';
-import { Link } from 'react-router';
 import React from 'react';
 import agent from '../../agent';
 import { connect } from 'react-redux';
diff --git a/src/components/ArticleList.js b/src/components/ArticleList.js
@@ -1,5 +1,3 @@
-'use strict';
-
 import ArticlePreview from './ArticlePreview';
 import ListPagination from './ListPagination';
 import React from 'react';
diff --git a/src/components/ArticlePreview.js b/src/components/ArticlePreview.js
@@ -1,5 +1,3 @@
-'use strict';
-
 import React from 'react';
 import { Link } from 'react-router';
 import agent from '../agent';
@@ -39,7 +37,7 @@ const ArticlePreview = props => {
     <div className="article-preview">
       <div className="article-meta">
         <Link to={`@${article.author.username}`}>
-          <img src={article.author.image} />
+          <img src={article.author.image} alt={article.author.username} />
         </Link>
 
         <div className="info">
diff --git a/src/components/Editor.js b/src/components/Editor.js
@@ -1,5 +1,3 @@
-'use strict';
-
 import ListErrors from './ListErrors';
 import React from 'react';
 import agent from '../agent';
diff --git a/src/components/Header.js b/src/components/Header.js
@@ -1,5 +1,3 @@
-'use strict';
-
 import React from 'react';
 import { Link } from 'react-router';
 
@@ -59,7 +57,7 @@ const LoggedInView = props => {
           <Link
             to={`@${props.currentUser.username}`}
             className="nav-link">
-            <img src={props.currentUser.image} className="user-pic" />
+            <img src={props.currentUser.image} className="user-pic" alt={props.currentUser.username} />
             {props.currentUser.username}
           </Link>
         </li>
diff --git a/src/components/Home/MainView.js b/src/components/Home/MainView.js
@@ -62,7 +62,7 @@ const mapStateToProps = state => ({
 });
 
 const mapDispatchToProps = dispatch => ({
-  onTabClick: (tab, pager, payload) => dispatch({ type: 'CHANGE_TAB', tab, pager, payload })
+  onTabClick: (tab, pager, payload) => dispatch({ type: CHANGE_TAB, tab, pager, payload })
 });
 
 const MainView = props => {
diff --git a/src/components/Home/index.js b/src/components/Home/index.js
@@ -20,9 +20,9 @@ const mapStateToProps = state => ({
 
 const mapDispatchToProps = dispatch => ({
   onClickTag: (tag, pager, payload) =>
-    dispatch({ type: 'APPLY_TAG_FILTER', tag, pager, payload }),
+    dispatch({ type: APPLY_TAG_FILTER, tag, pager, payload }),
   onLoad: (tab, pager, payload) =>
-    dispatch({ type: 'HOME_PAGE_LOADED', tab, pager, payload }),
+    dispatch({ type: HOME_PAGE_LOADED, tab, pager, payload }),
   onUnload: () =>
     dispatch({  type: HOME_PAGE_UNLOADED })
 });
diff --git a/src/components/ListErrors.js b/src/components/ListErrors.js
@@ -1,5 +1,3 @@
-'use strict';
-
 import React from 'react';
 
 class ListErrors extends React.Component {
diff --git a/src/components/Profile.js b/src/components/Profile.js
@@ -1,5 +1,3 @@
-'use strict';
-
 import ArticleList from './ArticleList';
 import React from 'react';
 import { Link } from 'react-router';
@@ -127,7 +125,7 @@ class Profile extends React.Component {
             <div className="row">
               <div className="col-xs-12 col-md-10 offset-md-1">
 
-                <img src={profile.image} className="user-img" />
+                <img src={profile.image} className="user-img" alt={profile.username} />
                 <h4>{profile.username}</h4>
                 <p>{profile.bio}</p>
 
@@ -169,4 +167,4 @@ class Profile extends React.Component {
 }
 
 export default connect(mapStateToProps, mapDispatchToProps)(Profile);
-export { Profile as Profile, mapStateToProps as mapStateToProps };
+export { Profile, mapStateToProps };
diff --git a/src/components/ProfileFavorites.js b/src/components/ProfileFavorites.js
@@ -1,5 +1,3 @@
-'use strict';
-
 import { Profile, mapStateToProps } from './Profile';
 import React from 'react';
 import { Link } from 'react-router';
@@ -12,7 +10,7 @@ import {
 
 const mapDispatchToProps = dispatch => ({
   onLoad: (pager, payload) =>
-    dispatch({ type: 'PROFILE_FAVORITES_PAGE_LOADED', pager, payload }),
+    dispatch({ type: PROFILE_FAVORITES_PAGE_LOADED, pager, payload }),
   onUnload: () =>
     dispatch({ type: PROFILE_FAVORITES_PAGE_UNLOADED })
 });
diff --git a/src/components/Settings.js b/src/components/Settings.js
@@ -1,9 +1,7 @@
 import ListErrors from './ListErrors';
 import React from 'react';
-import { Link } from 'react-router';
 import agent from '../agent';
 import { connect } from 'react-redux';
-import store from '../store';
 import {
   SETTINGS_SAVED,
   SETTINGS_PAGE_UNLOADED,
diff --git a/src/index.js b/src/index.js
@@ -1,17 +1,12 @@
-'use strict';
-
 import ReactDOM from 'react-dom';
 import { Provider } from 'react-redux';
 import React from 'react';
 import { Router, Route, IndexRoute, hashHistory } from 'react-router';
-import agent from './agent';
-import history from 'history';
 import store from './store';
 
 import App from './components/App';
 import Article from './components/Article';
 import Editor from './components/Editor';
-import Header from './components/Header';
 import Home from './components/Home';
 import Login from './components/Login';
 import Profile from './components/Profile';
diff --git a/src/middleware.js b/src/middleware.js
@@ -1,5 +1,3 @@
-'use strict';
-
 import agent from './agent';
 import {
   ASYNC_START,
diff --git a/src/reducer.js b/src/reducer.js
@@ -1,5 +1,3 @@
-'use strict';
-
 import article from './reducers/article';
 import articleList from './reducers/articleList';
 import auth from './reducers/auth';
diff --git a/src/reducers/article.js b/src/reducers/article.js
@@ -13,7 +13,6 @@ export default (state = {}, action) => {
         article: action.payload[0].article,
         comments: action.payload[1].comments
       };
-      break;
     case ARTICLE_PAGE_UNLOADED:
       return {};
     case ADD_COMMENT:
@@ -30,7 +29,7 @@ export default (state = {}, action) => {
         ...state,
         comments: state.comments.filter(comment => comment.id !== commentId)
       };
+    default:
+      return state;
   }
-
-  return state;
 };
diff --git a/src/reducers/articleList.js b/src/reducers/articleList.js
@@ -80,7 +80,7 @@ export default (state = {}, action) => {
     case PROFILE_PAGE_UNLOADED:
     case PROFILE_FAVORITES_PAGE_UNLOADED:
       return {};
+    default:
+      return state;
   }
-
-  return state;
 };
diff --git a/src/reducers/auth.js b/src/reducers/auth.js
@@ -20,12 +20,14 @@ export default (state = {}, action) => {
     case REGISTER_PAGE_UNLOADED:
       return {};
     case ASYNC_START:
-      if (action.subtype === 'LOGIN' || action.subtype === 'REGISTER') {
+      if (action.subtype === LOGIN || action.subtype === REGISTER) {
         return { ...state, inProgress: true };
       }
       break;
     case UPDATE_FIELD_AUTH:
       return { ...state, [action.key]: action.value };
+    default:
+      return state;
   }
 
   return state;
diff --git a/src/reducers/common.js b/src/reducers/common.js
@@ -64,7 +64,7 @@ export default (state = defaultState, action) => {
     case LOGIN_PAGE_UNLOADED:
     case REGISTER_PAGE_UNLOADED:
       return { ...state, viewChangeCounter: state.viewChangeCounter + 1 };
+    default:
+      return state;
   }
-
-  return state;
 };
diff --git a/src/reducers/editor.js b/src/reducers/editor.js
@@ -46,6 +46,8 @@ export default (state = {}, action) => {
       };
     case UPDATE_FIELD_EDITOR:
       return { ...state, [action.key]: action.value };
+    default:
+      return state;
   }
 
   return state;
diff --git a/src/reducers/home.js b/src/reducers/home.js
@@ -9,7 +9,7 @@ export default (state = {}, action) => {
       };
     case HOME_PAGE_UNLOADED:
       return {};
+    default:
+      return state;
   }
-
-  return state;
 };
diff --git a/src/reducers/profile.js b/src/reducers/profile.js
@@ -18,7 +18,7 @@ export default (state = {}, action) => {
       return {
         ...action.payload.profile
       };
+    default:
+      return state;
   }
-
-  return state;
 };
diff --git a/src/reducers/profileFavorites.js b/src/reducers/profileFavorites.js
@@ -11,7 +11,7 @@ export default (state = {}, action) => {
       };
     case PROFILE_FAVORITES_PAGE_UNLOADED:
       return {};
+    default:
+      return state;
   }
-
-  return state;
 };
diff --git a/src/reducers/settings.js b/src/reducers/settings.js
@@ -19,7 +19,7 @@ export default (state = {}, action) => {
         ...state,
         inProgress: true
       };
+    default:
+      return state;
   }
-
-  return state;
 };

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-'use strict';`
`2`		`-`
`3`	`1`	`import superagentPromise from 'superagent-promise';`
`4`	`2`	`import _superagent from 'superagent';`
`5`	`3`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-'use strict';`
`2`		`-`
`3`	`1`	`import ArticlePreview from './ArticlePreview';`
`4`	`2`	`import ListPagination from './ListPagination';`
`5`	`3`	`import React from 'react';`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-'use strict';`
`2`		`-`
`3`	`1`	`import ListErrors from './ListErrors';`
`4`	`2`	`import React from 'react';`
`5`	`3`	`import agent from '../agent';`