Skip to content

FIX: Cancel statement before closing to avoid leaking connections #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonasPoehler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIX: Cancel statement before closing to avoid leaking connections #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ebean-datasource/src/main/java/io/ebean/datasource/pool/ExtendedPreparedStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import java.sql.ResultSet;
import java.sql.ResultSetMetaData;
import java.sql.SQLException;
import java.sql.SQLFeatureNotSupportedException;
import java.sql.Time;
import java.sql.Timestamp;
import java.util.Calendar;
Expand Down Expand Up @@ -60,7 +61,15 @@ String cacheKey() {
* reuse the PreparedStatement.
*/
void closeDestroy() throws SQLException {
delegate.close();
if (!delegate.isClosed()) {
// Cancel might throw an exception when it is already closed
try {
delegate.cancel();
} catch (SQLFeatureNotSupportedException e) {
Log.trace("Canceling statement not supported by JDBC-driver");
}
delegate.close();
}
}

/**
Expand Down