Open
Conversation
The --proxy flag was not being used for downloading translated audio from Yandex S3 (vtrans.s3-private.mds.yandex.net), causing ETIMEDOUT errors when direct access to Yandex is blocked. This change passes the parsed proxyData through to axios download calls in both audio and subtitle download paths. Fixes downloads behind corporate firewalls and in regions where Yandex services are blocked. Changes: - src/download.js: Add proxyData parameter to downloadFile() - src/index.js: Pass proxyData to both downloadFile() calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --proxy flag was not being used for downloading translated audio from Yandex S3 (vtrans.s3-private.mds.yandex.net), causing ETIMEDOUT errors when direct access to Yandex is blocked.
This change passes the parsed proxyData through to axios download calls in both audio and subtitle download paths.
Fixes downloads behind corporate firewalls and in regions where Yandex services are blocked.
Changes:
Testing:
Tested with HTTP proxy on blocked network:
Manual Testing:
Tested on Windows 11 with multiple proxy configurations:
Test 1: HTTP proxy with auth