[Feature] Linear Interpolation (super simple)#13
Open
Tortuga-AM wants to merge 4 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces basic linear interpolation for the shooter and hood setpoints. Key changes include:
- Updating the shooter control call from calculate() to calculateWithVelocities().
- Adding a new constant (MEDIUM_SPEED) and interpolation arrays (ANGLES and DISTANCES) to the HoodedShooterSupersystemConstants.
- Incorporating a simple linear interpolation logic in HoodedShooterSupersystem using InterpolatingDoubleTreeMap.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/frc/robot/Subsystems/Shooter/ShooterIOSim.java | Updated shooter setpoint calculation with a new API method. |
| src/main/java/frc/robot/Subsystems/HoodedShooterSupersystem/HoodedShooterSupersystemConstants.java | Added new mathematical constants and interpolation data arrays. |
| src/main/java/frc/robot/Subsystems/HoodedShooterSupersystem/HoodedShooterSupersystem.java | Introduced interpolation logic for hood setpoint and updated shooter setpoint to return a constant. |
Comments suppressed due to low confidence (2)
src/main/java/frc/robot/Subsystems/Shooter/ShooterIOSim.java:61
- Verify that the new calculateWithVelocities method provides equivalent behavior to the old calculate method, so that the shooter control loop continues to perform as expected.
)
src/main/java/frc/robot/Subsystems/HoodedShooterSupersystem/HoodedShooterSupersystemConstants.java:13
- [nitpick] Consider updating placeholder constant names (e.g., FAKE_VALUE and FAKE_VALUE_2) and comments ('Random values and stuff') with clearer descriptions once the production values are determined.
public static final AngularVelocity MEDIUM_SPEED = RotationsPerSecond.of(1500);
src/main/java/frc/robot/Subsystems/HoodedShooterSupersystem/HoodedShooterSupersystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/Subsystems/HoodedShooterSupersystem/HoodedShooterSupersystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/Subsystems/HoodedShooterSupersystem/HoodedShooterSupersystem.java
Outdated
Show resolved
Hide resolved
GreenTomato5
approved these changes
Jun 23, 2025
Contributor
GreenTomato5
left a comment
There was a problem hiding this comment.
Looks fine to me, a couple comments but those might not be important. Merge if it looks good to you
Contributor
|
@Tortuga-AM lock in, get out of canada |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.