ospfclient: fix handling of port in use exception #20361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lou Berger <lberger@labn.net>
donaldsharp
reviewed
Jan 4, 2026
| self._s, self._ls = self._get_bound_sockets(port) | ||
| break | ||
| except OSError as error: | ||
| except Exception as error: |
Member
There was a problem hiding this comment.
I believe this breaks the error handling logic. The code is accesing error.errno but not all classes have this value. error.errno is only in OSError. Want this break then?
Member
Author
There was a problem hiding this comment.
I'm not sure - I know the current code didn't work as expected -- I'll do a test to confirm this error path...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error was not properly being caught in case Exception was not raised as an OSError - which is the case...