Skip to content

Fix compatibility with nginx-1.11.6+ #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix compatibility with nginx-1.11.6+ #51

wants to merge 2 commits into from

Conversation

@psulowicz
Copy link

@psulowicz psulowicz commented Feb 2, 2017

No description provided.

@awsumco awsumco mentioned this pull request Mar 14, 2017
Open
@nerux1
Copy link

nerux1 commented May 31, 2017

It works great with nginx version 1.12.0

@zakiharis
Copy link

zakiharis commented Oct 10, 2017 •
edited
Loading

Successfully purged with nginx 1.13.3

root@something:~# curl -i -X DELETE -H "Host: cdn.domain.test" localhost/files/file.txt
HTTP/1.1 200 OK
Server: nginx
Date: Tue, 10 Oct 2017 07:13:36 GMT
Content-Type: text/html
Content-Length: 282
Connection: keep-alive

<html>
<head><title>Successful purge</title></head>
<body bgcolor="white">
<center><h1>Successful purge</h1>
<br>Key : 248455226:0:/files/file.txt
<br>Path: /var/cache/nginx/8/c9/8890acdc10c07a1130c4d2337132cc98
</center>
<hr><center>nginx/1.13.3</center>
</body>
</html>

Before adding this patch

root@something:~# curl -i -X DELETE -H "Host: cdn.domain.test" localhost/files/file.txt
HTTP/1.1 502 Bad Gateway
Server: nginx
Date: Tue, 10 Oct 2017 06:58:08 GMT
Content-Type: text/html
Content-Length: 166
Connection: keep-alive

<html>
<head><title>502 Bad Gateway</title></head>
<body bgcolor="white">
<center><h1>502 Bad Gateway</h1></center>
<hr><center>nginx</center>
</body>
</html>

@szepeviktor
Copy link

szepeviktor commented Dec 30, 2017

@PiotrSikora Would it be possible to merge?

@kennylam777 kennylam777 mentioned this pull request Jan 18, 2018
Open
@July-G
Copy link

July-G commented Apr 28, 2018 •
edited
Loading

In nginx 1.12.2, I found the "separate location syntax" does not work, could anybody confirm?
When configuring with separate location syntax, I always get 404, seem it does not honor the "separate location" at all.

@jiajunsu
Copy link

jiajunsu commented Jun 7, 2018

This patch worked with 1.14.0.
@PiotrSikora Could you please merge it?

@randshell randshell mentioned this pull request Jun 26, 2020
Closed
@jbienkowski311
Fix compatibility with nginx 1.19.3+ (#1)
c8ca321 
* Fix compatibility with nginx 1.19.3+

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@psulowicz @nerux1 @zakiharis @szepeviktor @July-G @jiajunsu @jbienkowski311