Skip to content

Conversation

@MichaelHillcox
Copy link
Member

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces overridable minimum Y levels for dimensions with ceilings, allowing per-chunk customization of the minimum Y level used when rendering the map. It replaces the previous global custom min Y level setting with a more flexible system that supports both a default override value and per-chunk specific values.

Key Changes:

  • Replaced global USE_CUSTOM_MIN_Y_LEVEL with OVERRIDE_MIN_Y_LEVEL and added per-chunk min Y level support
  • Implemented ChunkPosWithMinY record and custom config value type for storing chunk-specific Y levels
  • Added clamping logic to ensure min Y values stay within dimension build height limits

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
gradle.properties Version bump from 2101.1.12 to 2101.1.13
HeightUtils.java Added per-chunk min Y lookup logic with dimension height clamping
FTBChunksClientConfig.java Migrated config from APPEARANCE to CUSTOM_BEHAVIOUR group and added ChunkPosCustomYSetValue for per-chunk settings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

MichaelHillcox and others added 2 commits October 25, 2025 20:40
…ientConfig.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MichaelHillcox MichaelHillcox requested a review from desht October 26, 2025 10:20
@MichaelHillcox MichaelHillcox merged commit cbba06f into 1.21.1/main Oct 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants