-
Notifications
You must be signed in to change notification settings - Fork 71
feat: overridable min_y levels for dimensions with ceilings #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces overridable minimum Y levels for dimensions with ceilings, allowing per-chunk customization of the minimum Y level used when rendering the map. It replaces the previous global custom min Y level setting with a more flexible system that supports both a default override value and per-chunk specific values.
Key Changes:
- Replaced global
USE_CUSTOM_MIN_Y_LEVELwithOVERRIDE_MIN_Y_LEVELand added per-chunk min Y level support - Implemented
ChunkPosWithMinYrecord and custom config value type for storing chunk-specific Y levels - Added clamping logic to ensure min Y values stay within dimension build height limits
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gradle.properties | Version bump from 2101.1.12 to 2101.1.13 |
| HeightUtils.java | Added per-chunk min Y lookup logic with dimension height clamping |
| FTBChunksClientConfig.java | Migrated config from APPEARANCE to CUSTOM_BEHAVIOUR group and added ChunkPosCustomYSetValue for per-chunk settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
common/src/main/java/dev/ftb/mods/ftbchunks/client/FTBChunksClientConfig.java
Outdated
Show resolved
Hide resolved
common/src/main/java/dev/ftb/mods/ftbchunks/util/HeightUtils.java
Outdated
Show resolved
Hide resolved
…ientConfig.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
common/src/main/java/dev/ftb/mods/ftbchunks/util/HeightUtils.java
Outdated
Show resolved
Hide resolved
common/src/main/java/dev/ftb/mods/ftbchunks/client/FTBChunksClientConfig.java
Outdated
Show resolved
Hide resolved
common/src/main/java/dev/ftb/mods/ftbchunks/client/FTBChunksClientConfig.java
Outdated
Show resolved
Hide resolved
common/src/main/java/dev/ftb/mods/ftbchunks/client/FTBChunksClientConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.