Skip to content

Replace pykokkos-base with currently supported pykokkos/base. Update kokkos#246

Merged
ABandet merged 6 commits intomainfrom
feature/pykokkos-base-to-pykokkos
Feb 25, 2026
Merged

Replace pykokkos-base with currently supported pykokkos/base. Update kokkos#246
ABandet merged 6 commits intomainfrom
feature/pykokkos-base-to-pykokkos

Conversation

@sframba
Copy link
Collaborator

@sframba sframba commented Feb 12, 2026

This PR corrects a few problems that prevent compilation with nvhpc. An if is added in cmake configuration files to use this compiler's flags instead of the standard gcc flags when needed. Also, pykokkos-base (now deprecated) is replaced with a newer version of pykokkos that replaces it in terms of functionality since December 2025.

@sframba sframba self-assigned this Feb 12, 2026
@sframba sframba added the bug Something isn't working label Feb 12, 2026
@ABandet ABandet added dependencies Pull requests that update a dependency file python Pull requests that update python code SCCACHE_OFF Turns of sccache in CI/CD builds labels Feb 12, 2026
@ABandet ABandet requested a review from Bubusch February 12, 2026 15:06
@Bubusch
Copy link
Contributor

Bubusch commented Feb 13, 2026

later we might want to decrease ENABLE_VIEW_RANKS (default to 4) ton speed up build time

@sframba
Copy link
Collaborator Author

sframba commented Feb 23, 2026

@ABandet @acitrain is this good to merge?

@ABandet
Copy link
Collaborator

ABandet commented Feb 24, 2026

Good on my side. Keep in mind this with soon change with TPL PR.

@sframba
Copy link
Collaborator Author

sframba commented Feb 25, 2026

I propose we merge this so that the changes can be included in the TPL PR. @acitrain can you merge please?

@ABandet
Copy link
Collaborator

ABandet commented Feb 25, 2026

That's already the case. TPL PR will be merge later so I will merge this now. Thanks !

@ABandet ABandet merged commit 2571d1b into main Feb 25, 2026
5 checks passed
@ABandet ABandet linked an issue Mar 24, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file python Pull requests that update python code SCCACHE_OFF Turns of sccache in CI/CD builds

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove pykokkos-base

3 participants