Merged
Conversation
acitrain
added
enhancement
Closed
ABandet
requested changes
Feb 24, 2026
Collaborator
ABandet
left a comment
ABandet
left a comment
There was a problem hiding this comment.
We should have some sort of security where user cannot activate HIP and CUDA at the same time.
Collaborator
Author
Yes you are right, it is done ! :) |
Bubusch
requested changes
Mar 13, 2026
| float const v5 = lambda * Jp1 * Jr2 + mu * Jp2 * Jr1; | ||
|
|
||
| #ifdef __CUDACC__ | ||
| #if defined(__CUDACC__) || defined(__HIPCC__) |
Contributor
There was a problem hiding this comment.
can we set a common macro ?
#define GPU_ENABLED (defined(__CUDACC__) || defined(__HIPCC__))then reuse as
#if GPU_ENABLEDso it can be easily modified/extended if need be.
ABandet
approved these changes
Mar 20, 2026
Collaborator
ABandet
left a comment
ABandet
left a comment
There was a problem hiding this comment.
Works on enbata (plafrim machine). But kind of slow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reenable HIP support
It has been tested on AMD architecture, we just need to check performance in the future