Skip to content

fix boundary classifier#256

Merged
Bubusch merged 7 commits intomainfrom
bugfix/fixboundaryonmpi
Mar 11, 2026
Merged

fix boundary classifier#256
Bubusch merged 7 commits intomainfrom
bugfix/fixboundaryonmpi

Conversation

@Bubusch
Copy link
Contributor

@Bubusch Bubusch commented Mar 9, 2026

  • remove duplicate in boundaries_t array between models and model builders -> they are now called only in builders
  • remove unnecessary freeSurfaceTag_ array -> it is already a tag in boundaries_t array
  • split boundary classifiers into separate classes for SOLID implementation
  • add unit tests for boundary classifiers to ensure compatibility with MPI
  • model isBoundaryFace and isFreeSurface methods use boundaries_t array if provided

@Bubusch Bubusch linked an issue Mar 9, 2026 that may be closed by this pull request
Fix bug with boundary face on MPI #254
Closed
Bubusch
Bubusch commented Mar 9, 2026
View reviewed changes
src/model/mesh/impl/model/struct/include/model_struct.h
static_cast<ScalarType>(BoundaryFlag::InteriorNode))
return false;
}
return true;
Copy link
Contributor Author

@Bubusch Bubusch Mar 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acitrain @ABandet I am a unsure on how we should proceed here.
Shall we only rely on boundaries_t_ and assumed it is filled, or shall we keep the face_connectivity_ fallback ? Same question for isFreeSurface method.

@Bubusch Bubusch requested a review from sframba March 9, 2026 16:41
@Bubusch Bubusch self-assigned this Mar 9, 2026
@Bubusch Bubusch added bug Something isn't working python Pull requests that update python code pyfwi Task related to TTE private repos for pyfwi labels Mar 9, 2026
@Bubusch
Copy link
Contributor Author

Bubusch commented Mar 11, 2026

Top -> before fix in mesher + funtides
Bot -> after fix
3D cases with 2 MPI ranks
image

@Bubusch Bubusch merged commit 1362645 into main Mar 11, 2026
5 checks passed
@Bubusch Bubusch deleted the bugfix/fixboundaryonmpi branch March 11, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acitrain acitrain acitrain approved these changes

@ABandet ABandet Awaiting requested review from ABandet

@Victor-M-Gomes Victor-M-Gomes Awaiting requested review from Victor-M-Gomes

@sframba sframba Awaiting requested review from sframba

Assignees

@Bubusch Bubusch

Labels

bug Something isn't working pyfwi Task related to TTE private repos for pyfwi python Pull requests that update python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix bug with boundary face on MPI

2 participants

@Bubusch @acitrain