remove compilation flag use_kokkos and vector version#265
Conversation
ABandet
added
SEM
Bubusch
left a comment
Bubusch
left a comment
There was a problem hiding this comment.
readme.md and GitHub workflows also need to be updated to remove vector builds.
cmake/KokkosConfig.cmake
Outdated
| else() | ||
| message(STATUS "Building the application with Kokkos.") | ||
| set(USE_VECTOR OFF CACHE BOOL "" FORCE) | ||
| message(STATUS "Building the application with Kokkos.") |
There was a problem hiding this comment.
message not really needed since we always build with kokkos now
There was a problem hiding this comment.
maybe even this file is not required anymore
There was a problem hiding this comment.
You are right. I'll remove the file and add find_package function into KokkosUtils.cmake.
| message(STATUS "Programming Models:") | ||
| message(STATUS " USE_VECTOR: ${USE_VECTOR}") | ||
| message(STATUS " USE_KOKKOS: ${USE_KOKKOS}") | ||
| message(STATUS " ENABLE_CUDA: ${ENABLE_CUDA}") |
There was a problem hiding this comment.
why remove ENABLE_CUDA and ENABLE_HIP?
There was a problem hiding this comment.
These flags are handled by Kokkos now.
Our code should be independent of the GPU/HOST implementation. This part is handled by kokkos and TPL (or users installation).
| option(USE_VECTOR "Use vectors." OFF) | ||
| option(USE_KOKKOS "Use KOKKOS to parallelise loops" OFF) | ||
| option(USE_KOKKOS_TEAMS "use hierarchical parallelism in Kokkos" OFF) | ||
| option(ENABLE_CUDA "Enable cuda compilation" OFF) |
There was a problem hiding this comment.
why remove ENABLE_CUDA and ENABLE_HIP?
There was a problem hiding this comment.
These flags are handled by Kokkos now.
Our code should be independent of the GPU/HOST implementation. This part is handled by kokkos and TPL (or users installation).
2 participants
Kokkos version is now the only version used.
This PR aims to remove the vector version and the USE_KOKKOS cmake flag.
USE_VECTOR is no longer used.