Skip to content

293 draw cbar arg not backward compatible#296

Merged
shitabishmam merged 3 commits intodevfrom
293-draw_cbar-arg-not-backward-compatible
Feb 10, 2026
Merged

293 draw cbar arg not backward compatible#296
shitabishmam merged 3 commits intodevfrom
293-draw_cbar-arg-not-backward-compatible

Conversation

@julian-belina
Copy link
Collaborator

This pull request resolves the following issue: #293.

It also reduces the release pipeline, since most dependencies are very stable.

It also increases the reliability of downloading test data.

@julian-belina julian-belina linked an issue Feb 10, 2026 that may be closed by this pull request
@julian-belina julian-belina marked this pull request as ready for review February 10, 2026 14:18
@shitabishmam shitabishmam merged commit b832315 into dev Feb 10, 2026
13 checks passed
shitabishmam added a commit that referenced this pull request Feb 10, 2026
* add file existence check to loadVector

* fix test_createVector by setting right driverName

* ruff

* add file exists check after test_createVector

* Add initial format

* Apply spell checking

* Apply more formatting

* Add doc coverage

* Update badge path

* Update badge path

* Update Juelich logo

* Fix typo

* Remove unecessary dependencies

* remove redundant checks on string and add additional conditions

* Apply formatter reccomendations

* update and expand test for loadVector

* move import out of test function and reorganize

* Add more type hints, add retries download, adjust publication images (#255)

* Add more type hints, add retries download, adjust publication images

* Remove figure saving from example 7

* "Update example 7"

* "Formart example 7"

* Fix example 7 add geokit reviewer team to CODEOWNER"

* reapply ruff

* Initial

* 95 polygonize matrix fails (#256)

* add fix back in for all false matrix

* add test back in

* update test

---------

Co-authored-by: Shitab <s.ishmam@fz-juelich.de>

* suppress type checks for parts of the loadVector test

* Fix setting the meta data during gdal warp

* Deprecate current contours behavior, remove test for gdal<3.0

* Adjust deprecation warning call

* Remove kwags argument as there is no obvious use for it, split create_raster_tests, add type hints to create raster function and raster info, add matrix comparison for fill create raster, determine gdal raster datat types as strings

* Remove direct call for create raster test

* Silence warning for contour tests, assert warning is raised in polygonize False test, add type hints to polygonize matrix function, fix wrong use  shrink argument in many tests

* Change test name for polgynoze false test

* rename ouput dataset variable

* update doctsring description for raster_band_index

* "Fix behavior of extractValues and and make necessary changes to InterpolateValues"

* "Add docstrings to Location"

* Change noData=None in drawRaster function

* "Fix colorbars and axes problems in drawRaster and drawGeom"

* "Update example 7 for new plotting functions"

* "Adjust the layout setting for raster plots"

* Remove outputs from example 7

* Remove savefig

* "Format example 7"

* Add a description of the new functions. Add the new case to handle OGR geometry points without an internally stored spatial reference system.

* "Remove comment"

* "Rename pointSRS and remove unsused test"

* ruff format imports

* 264 fix geokit plotting functions (#267)

* Change noData=None in drawRaster function

* "Fix colorbars and axes problems in drawRaster and drawGeom"

* "Update example 7 for new plotting functions"

* "Adjust the layout setting for raster plots"

* Remove outputs from example 7

* Remove savefig

* "Format example 7"

* ruff format imports

---------

Co-authored-by: Shitab <s.ishmam@fz-juelich.de>

* "Change data type handling to handle overflow errosrors and user-defined minimum data types correctly"

* Add warning message in case user defined data type differs from necessary data type

* Add more doc strings to c data handler

* "Add warning to some examples"

* Add formatting

* "Remove macos 13"

* 270 numpybool (#272)

* remove np.bool

* Use backwards compatiabile numpy bool type

* Test scipy versions

* Reduce release pipeline

* Test for newer scipy versions

* Test for newer scipy versions

* Remove branch from scipy

* Fix scipy min version for pull

---------

Co-authored-by: Christoph Winkler <c.winkler@fz-juelich.de>

* 274 rasterinterpolatevalues cannot deal with point lists of len 1 anymore (#275)

* Intermediate

* Fix interpolateValues with len(list)=1 for points

* Fix issue from other pr

* "Fix issues with literals in python 3.10"

* Readd data type fix

* Fix example 8

* Add a distinction for GDAL versions.

* import pyplot at the beginning

* "Adjust lower limits"

* Add first examples

* replace lambda function

* make xo and yo private

* 269 enable arg in ruff to check for unused arguments (#273)

* Fix unused imports

* Add filter warning

* replace lambda function

* make xo and yo private

* also implement fix in test_interpolateValues_from_list

---------

Co-authored-by: Shitab <s.ishmam@fz-juelich.de>

* update vector exmaples

* Apply formatter

* "Fix colorby plotting in geoms"

* Change order of example notebooks for vectors

* Add examples for the Extent class.

* Add option to download with header from zenodo, remove pooch and tdqm, paralelize downloads

* "Pass secretes to workflows for zenodo"

* "rename inconcistency"

* Update geokit/core/geom.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Julian Belina <56728940+julian-belina@users.noreply.github.com>

* Update geokit/core/get_test_data.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Julian Belina <56728940+julian-belina@users.noreply.github.com>

* Update geokit/core/geom.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Julian Belina <56728940+julian-belina@users.noreply.github.com>

* Update geokit/core/get_test_data.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Julian Belina <56728940+julian-belina@users.noreply.github.com>

* Update geokit/core/get_test_data.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Julian Belina <56728940+julian-belina@users.noreply.github.com>

* Refactor download_and_extract_parallel method and update example notebook for clarity; add requests dependency

* apply ruff formatter

* consistent fill handling

* set noData value of contextRaster if not given

* allow dtype specified or selected automatically

* remove old fill and dtype args

* ruff

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Shitab Ishmam <47360532+shitabishmam@users.noreply.github.com>

* "Add flag to explicitly calculate raster statistics because its computationaly expensive" (#287)

* convert numpy arrays to list of coordinate pairs always (#282)

* convert numpy arrays to list of coordinate pairs always

* apply ruff

---------

Co-authored-by: Julian Belina <56728940+julian-belina@users.noreply.github.com>

* "Add hatchling as build backend. Add py.typed to indicate enabled type hinting" (#290)

* Remove warnings, remove fill value

* enable multi version documentation

* Remove output

* "Update vector section"

* add more changes

* Add notebooks to table of contents, clear outputs of notebooks

* Apply ruff formatter

* "Morve example"

* Add more docs output

* Update jupyter book dependency

* Update some links and eplxanations

* Update link

* "Add geokit logo"

* Update headline

* Update headline

* Enlarge Jülich logo

* Update applicatione example naming and Jülich header width

* "Fix typos"

* Update geokpackage example

* update .md files

* Update examples

* updates

* update

* add updated examples for RegionMask

* update examples 1 and 2

* create smaller examples for RegionMask and add all to subdirectory

* Update examples

* Fix boundary example, apply ruff formatter

* Add subsection to geometries, removed unnecessary md file, udpate headings

* Update Headings in create geometry examples

* Update the geometries description

* Update geometries and extent objects, add more links to geodata

* Update vector example, remove old examples

* Apply ruff formatter2

* Fix bugs in examples update configration examples

* Rearrange examples

* Apply ruff formatter

* Fix first batch of typos

* Fix seconds batch of errors

* Remove outputs

* Update extract vector feature withhin region example

* Fix example _03_extract_vector_features_within_region and apply ruff formatter

* "Update regionmask examples"

* Update examples to combine multiple files

* Apply ruff formatter

* Rename examples

* Update overview

* Increase Geokit Logo size

* Update license and of conduct

* Change to mkdocs documentation

* Apply ruff formatter

* Update readtheocs yaml

* Adjust ci path, add autoexecute to notebooks

* Fix workflows

* Test dependency ranges

* Replace geokit with ethos.geokit, remove test on push

* Fix more spelling and grammar mistakes

* gdal and geopandas, increment version limits

* "Update dependency ranges"

* Update release pipeline

* 293 draw cbar arg not backward compatible (#296)

* Use a smaller release pipeline, remove draw_cbar argument. Increase reliablity of downloads

* Speed up test pipeline

* Remove double formatting job

---------

Signed-off-by: Shitab Ishmam <47360532+shitabishmam@users.noreply.github.com>
Signed-off-by: Julian Belina <56728940+julian-belina@users.noreply.github.com>
Co-authored-by: Christoph Winkler <c.winkler@fz-juelich.de>
Co-authored-by: Shitab <s.ishmam@fz-juelich.de>
Co-authored-by: Shitab Ishmam <47360532+shitabishmam@users.noreply.github.com>
Co-authored-by: Lana535 <l.soeltzer@fz-juelich.de>
Co-authored-by: Christoph Winkler <64524976+chrisjwin@users.noreply.github.com>
Co-authored-by: d.marmullaku <d.marmullaku@fz-juelich.de>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@julian-belina julian-belina deleted the 293-draw_cbar-arg-not-backward-compatible branch February 10, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

draw_cbar arg not backward compatible

2 participants