Conversation
|
The failed tests seems to be due to two things:
https://github.com/FZJ-INM1-BDA/siibralab/blob/xgui3783-patch-1/%2Btest/TestParcellations.m#L32 end up calling https://github.com/FZJ-INM1-BDA/siibralab/blob/xgui3783-patch-1/%2Bsiibra/%2Bitems/%2Bmaps/ParcellationMap.m#L13-L16 My understanding is that the string (We have have a similar issue with |
This seems to be triggered due to superficial fibre bundles. I bypassed it atm to check the issue 2 |
|
I noticed that spaces of julich brain 2.9 is not populated for some reason: Id: "minds/core/parcellationatlas/v1.0.0/94c1125b-b87e-45e4-901c-00daee7f2579-290"
Name: "Julich-Brain Cytoarchitectonic Atlas (v2.9)"
Atlas: [1×1 siibra.items.Atlas]
Modality: "cytoarchitecture"
Description: ""
RegionTree: [1×1 digraph]
Regions: [1×578 siibra.items.Region]
Spaces: [1×0 siibra.items.Space] |
|
It seems one has to supply a Space object instead of a string to @valentin-pinkau and @xgui3783 Is this the intended design? Shall we bring fuzzy matching back? |
Name (and ID) of mebrain parcellation has been updated at FZJ-INM1-BDA/siibra-configurations@614ecce7 .
This PR updates the test to reflect this change.