Skip to content

fix: updated mebrains parcellation name#49

Open
xgui3783 wants to merge 2 commits intomainfrom
xgui3783-patch-1
Open

fix: updated mebrains parcellation name#49
xgui3783 wants to merge 2 commits intomainfrom
xgui3783-patch-1

Conversation

@xgui3783
Copy link
Copy Markdown
Member

Name (and ID) of mebrain parcellation has been updated at FZJ-INM1-BDA/siibra-configurations@614ecce7 .

This PR updates the test to reflect this change.

@xgui3783
Copy link
Copy Markdown
Member Author

The failed tests seems to be due to two things:

  1. @AhmetNSimsek also noticed when running it on his local machine
      Error using arrayfun
      Non-scalar in Uniform output, at index 7, output 1.
      Set 'UniformOutput' to false.
  1. getParcellationMap (Unfortunately, not very adept at debugging matlab code, so following is a lot of conjectures)

https://github.com/FZJ-INM1-BDA/siibralab/blob/xgui3783-patch-1/%2Btest/TestParcellations.m#L32

            julich = siibra.getParcellation("human", "julich 2.9");
            labeledMapMNI = julich.parcellationMap("MNI Colin 27").fetch(); # this line

calls https://github.com/FZJ-INM1-BDA/siibralab/blob/xgui3783-patch-1/%2Bsiibra/%2Bitems/Parcellation.m#L59

        function map = parcellationMap(obj, space)
            map = siibra.items.maps.ParcellationMap(obj, space); # this line
        end

end up calling https://github.com/FZJ-INM1-BDA/siibralab/blob/xgui3783-patch-1/%2Bsiibra/%2Bitems/%2Bmaps/ParcellationMap.m#L13-L16

        function obj = ParcellationMap(parcellation, space)
            obj.Parcellation = parcellation;
            obj.Space = space;
        end

My understanding is that the string "MNI Colin 27" end up passing to ParcellationMap, as if it is a Space object. Somewhere along the chain, we would have to call "fuzzyMatch" (?)

(We have have a similar issue with Region.continuousMap)

@AhmetNSimsek AhmetNSimsek self-assigned this Jan 24, 2025
@AhmetNSimsek
Copy link
Copy Markdown
Collaborator

  Error using arrayfun
  Non-scalar in Uniform output, at index 7, output 1.
  Set 'UniformOutput' to false.

This seems to be triggered due to superficial fibre bundles. I bypassed it atm to check the issue 2

@AhmetNSimsek
Copy link
Copy Markdown
Collaborator

I noticed that spaces of julich brain 2.9 is not populated for some reason:

Id: "minds/core/parcellationatlas/v1.0.0/94c1125b-b87e-45e4-901c-00daee7f2579-290"
Name: "Julich-Brain Cytoarchitectonic Atlas (v2.9)"
Atlas: [1×1 siibra.items.Atlas]
Modality: "cytoarchitecture"
Description: ""
RegionTree: [1×1 digraph]
Regions: [1×578 siibra.items.Region]
Spaces: [1×0 siibra.items.Space]

@AhmetNSimsek
Copy link
Copy Markdown
Collaborator

It seems one has to supply a Space object instead of a string to <parcellation>.parcellationMap(Space).
see 1d8d6f3#diff-5fa98f955635981ac7f3bfa55e70241f995634cae7e00b493dd42a601730dd84L51-R60

@valentin-pinkau and @xgui3783 Is this the intended design? Shall we bring fuzzy matching back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants