Skip to content

Commit ce0ec88

Browse files
committed
fix and improve icon caching
1 parent 0005730 commit ce0ec88

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

app/lib/domain/services/generic_website.dart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ class GenericWebsiteService extends _$GenericWebsiteService {
291291
}
292292

293293
Future<BrowserIcon?> getCachedIcon(Uri url) async {
294-
if (url.scheme.startsWith('http')) {
294+
if (url.scheme.startsWith('https') || url.scheme.startsWith('http')) {
295295
final cachedBrowserIcon = _browserIconCache.get(url.origin);
296296
if (cachedBrowserIcon != null) {
297297
return cachedBrowserIcon;
@@ -326,7 +326,10 @@ class GenericWebsiteService extends _$GenericWebsiteService {
326326
waitOnNetworkLoad: waitOnNetworkLoad,
327327
);
328328

329-
// unawaited(_cacheRepository.cacheIcon(url, result.image));
329+
if (result.source != IconSource.generator &&
330+
result.source != IconSource.memory) {
331+
await _cacheRepository.cacheIcon(url, result.image);
332+
}
330333

331334
return _browserIconCache.set(
332335
url.origin,

0 commit comments

Comments
 (0)