Move to next token when using the tabulator #573
Merged
+58
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit finicky to use as it doesn't grab focus by default (i.e. tabbing whilst not editing should still mostly be old behaviour), and tabbing twice to skip a isn't a thing either. Although both issues are more or less connected to each other.
Resolving the loss of focus on tabbing issue probably requires a small refractor in
IdentifierPanel#refreshReferenceto not throw out the oldConvertingTextFieldinstance. However, that is conjecture on my side, the actual fix might be more involved or simplier - although I personally haven't managed to find a clear-cut approach beyond this lead after two hours of trying.This PR also introduces a slight visual bug where when the user maps tokens in a short amount of time, so highlight painters will highlight the wrong sections of text. However, as the root source is not exactly related to this PR and resolving it would be a bit more involved I decided to not include such a change in this PR for now. I may try to resolve it if requested though (though for a small visual glitch that resolves itself after a second of waiting resolving it might be a bit overkill anyways)
Closes #113